Hydraulic rescue tool refactoring

[FabianK3]

Introduction

The recently to atmos added hydraulic rescue tool is a robotic tool and has none of the common item/tool properties. This PR refactors the tool to a non-robotic version and fixes a bug in the recently added functionality (#20138 - Airlocks can be opened instantly by moving during the action duration).

What changed?

• Added /obj/item/crowbar/hydraulic_rescue_tool to tools.dm
• Removed robotic version under AI (/obj/item/crowbar/robotic/jawsoflife)
• Updated all occurrences (Sprite label due to updating the sprite filename)
• Fix action skip bug in airlock.dm when using the tool (See 5cc808b)

[FabianK3]

!review

[FluffyGhoster]

Jaws of life is a historical name, keep it

[FabianK3]

Jaws of life is a historical name, keep it

How is it a historical name? As far as i know, the tool only was available for the AI shell previously.

I don't think "jaws of life" is a very good name for a couple of reasons.

• "Jaws of life" is a U.S. Trademark for a company producing rescue tools, i don't think that fits well into the Aurora universe, as we are already trying to not go with IRL-names so far.
• "Jaws of life" immediately sparked confusion with it's name after my initial PR for some people, including other developers, because the term isn't widely known enough, especially outside the U.S.. There also seems to be a sentiment to specifically not call it that for some.
• I kept the term mentioned in the description for its legacy.

[FluffyGhoster]

How is it a historical name? As far as i know, the tool only was available for the AI shell previously.

I don't think "jaws of life" is a very good name for a couple of reasons.

* "Jaws of life" is a U.S. Trademark for a company producing rescue tools, i don't think that fits well into the Aurora universe, as we are already trying to not go with IRL-names so far.

* "Jaws of life" immediately sparked confusion with it's name after my initial PR for some people, including other developers, because the term isn't widely known enough, especially outside the U.S.. There also seems to be a sentiment to specifically not call it that for some.

* I kept the term mentioned in the description for its legacy.

They are called jaws of life as that was a coined term (https://en.wikipedia.org/wiki/Hydraulic_rescue_tool), they're called jaws of life in TG-derived codebases and it's a tool that has been there historically as far back as to when I started playing SS13 and here it's called jaws of life too (it's just pathed under robotic crowbars instead of being a general one)

[FabianK3]

They are called jaws of life as that was a coined term (https://en.wikipedia.org/wiki/Hydraulic_rescue_tool), they're called jaws of life in TG-derived codebases and it's a tool that has been there historically as far back as to when I started playing SS13 and here it's called jaws of life too (it's just pathed under robotic crowbars instead of being a general one)

Granted, colloquially in US English it may be known as Jaws of life, yet this still doesn't address the issue that people that are non-natives speaker are not well familiar with the term. It likely has never been an issue because, as it seems, the tool has not received much use on Aurora yet. Furthermore i still think that because it is a brand name nonetheless it doesn't have its place in our setting after all.

The reasoning here seems to rely on an appeal to tradition, suggesting that because this tool was initially implemented this way, it should remain unchanged. I think however, this alone doesn’t justify avoiding changes.

Edit: Shortened quote

[FluffyGhoster]

Granted, colloquially in US English it may be known as Jaws of life, yet this still doesn't address the issue that people that are non-natives speaker are not well familiar with the term. It likely has never been an issue because, as it seems, the tool has not received much use on Aurora yet. Furthermore i still think that because it is a brand name nonetheless it doesn't have its place in our setting after all.

The reasoning here seems to rely on an appeal to tradition, suggesting that because this tool was initially implemented this way, it should remain unchanged. I think however, this alone doesn’t justify avoiding changes.

Edit: Shortened quote

No, it's an appeal to standard: It's both called this way already and is also called this way in other codebases, that's how it's known for outside of Aurora too, in both TG and Bay branches; it's how the tool is known, both in colloquial usage, on the field and across the various codebases

It doesn't mean it has to remain the same necessarily, there might be other compelling reasons to rename it, but I don't see them here, which is why I'm saying not to do that

[FabianK3]

No, it's an appeal to standard: It's both called this way already and is also called this way in other codebases, that's how it's known for outside of Aurora too, in both TG and Bay branches; it's how the tool is known, both in colloquial usage, on the field and across the various codebases

If you are referring on how the tool is named in the codebase,
we can call it jawsoflife again, i don't have a strong opinion on that. That said, both on TG and Bay the name in the code differs, as does the actual implementation, while i don't mind the agreed upon naming in the code, i find the argument has not much value for the long run.

It doesn't mean it has to remain the same necessarily, there might be other compelling reasons to rename it, but I don't see them here, which is why I'm saying not to do that

If you are referring on how the tool is named in-game,
then i do not fully understand how my arguments regarding the reference to a US trademark/brand in the Aurora universe and the issue of the term bearing no meaning to non-native speakers, are not compelling reasons to rename it.

[FluffyGhoster]

If you are referring on how the tool is named in-game, then i do not fully understand how my arguments regarding the reference to a US trademark/brand in the Aurora universe and the issue of the term bearing no meaning to non-native speakers, are not compelling reasons to rename it.

As per the wikipedia article I linked, it's not just a brand name, it's how it's known as a tool - This is personal preference in the end, but I think there's no compelling reason to use a different name than what you find in the other codebases, and what it was known as

[FabianK3]

The wikipedia article is called "Hydraulic rescue tool". "Jaws of life" is a "also known as"-reference. Additionally it's ambiguous because it also seems to refer to a group of tools as well.

The name "jaws of life" is, however, used colloquially to describe other hydraulic rescue tools.

Note that the wiki:talk page also mentions concerns about naming it officially "Jaws of life".

---

The wiki article about Holmatro (another company producing rescue tools) explicitly mentions "Jaws of life" as just a reference to a trademark of another company:

Although sometimes colloquially called "jaws of life", that term is a registered trademark of Hurst, a North Carolina-based competitor making similar devices.

---

As per the wikipedia article I linked, it's not just a brand name, it's how it's known as a tool - This is personal preference in the end, but I think there's no compelling reason to use a different name than what you find in the other codebases, and what it was known as

The issue is, the first time the tool got mentioned i had to goggle it, when i put my first PR up, people asked what it is and googled it, after that another person came up with the information (unofficially) that the name is ambiguous and seemingly frowned upon as well.

All in all, while the term might be known in regions/circles as "Jaws of life", it's a U.S. term, brand and trademark and multiple people not knowing about it shows that the term has issues. I see that the term is becoming a proprietary eponym, but the topic seems to niche to be common knowledge.

Further more, i continue to see an issue with the name within our game setting considering we are using a brand name (or tool branded by a company) 400 years later. I don't think cross-codebase standards are a good enough reason to ignore this either.

Edit: Grammar, fix link

[FluffyGhoster]

Thank you for the research and evidences presented, after reviewing the other wikipedia article and the talk page with the info you presented, I concede the debate