distanceGround() and updatePosition() using TrajectorySetpoint #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Jul 24, 2024
px4_ros2_cpp/src/control/setpoint_types/experimental/trajectory.cpp
Outdated
Show resolved
Hide resolved
dakejahl
force-pushed
the
pr-enhancements
branch
from
2d460ad to
b2c0440
Compare
|
Something else I've noticed is that you cannot control both position and velocity simultaneously. For precision land for example you want to control XY position and Z velocity but when I send a Z velocity setpoint PX4 no longer controls the XY position. |
dakejahl
changed the title
|
@bkueng thoughts? |
|
Is there any progress with this PR? |
bkueng
reviewed
Sep 2, 2024
px4_ros2_cpp/include/px4_ros2/control/setpoint_types/experimental/trajectory.hpp
Show resolved
Hide resolved
dakejahl
force-pushed
the
pr-enhancements
branch
from
17e660f to
b488dd3
Compare
|
@bkueng I rebased and added a comment to the function declaration |
|
Thanks, I fixed the remaining CI issue and applied it to main |
|
Danke! @bkueng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.