Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system_state: expand vehicle telemtry interfaces #62

Merged
merged 3 commits into from
Nov 4, 2024
Merged

system_state: expand vehicle telemtry interfaces #62

merged 3 commits into from
Nov 4, 2024

Conversation

GuillaumeLaine
Copy link
Member

@GuillaumeLaine GuillaumeLaine commented Oct 29, 2024 •
edited
Loading

Changes

  • Expand vehicle telemetry interfaces by introducing the following subscription classes:
    • Battery
    • HomePosition
    • LandDetected
    • VehicleStatus
    • VtolStatus
  • Modify rtl_replacement example to use LandDetected subscription class
  • (Refactor) Move odometry/subscription.hpp -> utils/subscription.hpp as it is now used in both odometry/ and vehicle_state/ modules

Testing

  • rtl_replacement example works as expected in SITL
  • Message compatibility OK with new added messages. Checked APX4 (tag: v1.14.0-3.1.1-beta4) against px4_msgs (tag: 3.1.0), both latest.

@GuillaumeLaine GuillaumeLaine marked this pull request as ready for review October 29, 2024 12:07
@GuillaumeLaine GuillaumeLaine requested a review from bkueng October 29, 2024 12:15
bkueng
bkueng reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

px4_ros2_cpp/include/px4_ros2/vehicle_state/land_detected.hpp Outdated Show resolved Hide resolved
px4_ros2_cpp/include/px4_ros2/vehicle_state/land_detected.hpp Outdated Show resolved Hide resolved
px4_ros2_cpp/include/px4_ros2/vehicle_state/vehicle_status.hpp Show resolved Hide resolved
px4_ros2_cpp/include/px4_ros2/vehicle_state/vtol_status.hpp Outdated Show resolved Hide resolved
px4_ros2_cpp/src/vehicle_state/battery.cpp Outdated Show resolved Hide resolved
@GuillaumeLaine GuillaumeLaine force-pushed the add_vehicle_state branch 3 times, most recently from ac8a945 to 311968c Compare October 31, 2024 14:57
bkueng
bkueng approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks all good.
Can you squash the last commit into the previous ones?

@GuillaumeLaine GuillaumeLaine merged commit 5da845a into main Nov 4, 2024
9 checks passed
@GuillaumeLaine GuillaumeLaine deleted the add_vehicle_state branch November 4, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeLaine @bkueng