Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated property #81

Merged
merged 2 commits into from
Jul 19, 2023
Merged

fix deprecated property #81

merged 2 commits into from
Jul 19, 2023

Conversation

slonokot
Copy link
Contributor

@slonokot slonokot commented Jul 16, 2023 •
edited
Loading

Overview

Github Issue: #82

goreleaser have deprecated archives.replacements property and failed releasing v0.0.12 shore-delete

Summary (required always)

Notes

Checklist

  • My pull request title follows the format <username>/<gh-issue-#number>:<short-description>
  • My code passes existing unit tests
  • My code follows the code style set for the project
  • I have added at least one reviewer for this PR

@slonokot slonokot requested a review from a team as a code owner July 16, 2023 07:27
@slonokot slonokot self-assigned this Jul 16, 2023
@slonokot slonokot added the bug Something isn't working label Jul 16, 2023
@OmriGilhar
Copy link
Contributor

@slonokot Can you please document a local test of this change?
Thanks!

@slonokot
Copy link
Contributor Author

It creates files according to the previous naming pattern
image

@slonokot slonokot linked an issue Jul 19, 2023 that may be closed by this pull request
goreleaser archives.replacements deprecated and and fails release process #82
Closed
1 task
OmriGilhar
OmriGilhar approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@OmriGilhar OmriGilhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@slonokot slonokot merged commit 567fcf5 into main Jul 19, 2023
12 checks passed
@slonokot slonokot deleted the slonokot/fix_goreleaser branch July 19, 2023 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OmriGilhar OmriGilhar OmriGilhar approved these changes

Assignees

@slonokot slonokot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

goreleaser archives.replacements deprecated and and fails release process
2 participants
@slonokot @OmriGilhar