Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OSL reference implementation #13

Open
virtualritz opened this issue Oct 6, 2020 · 1 comment
Open

Fix OSL reference implementation #13

virtualritz opened this issue Oct 6, 2020 · 1 comment

Comments

@virtualritz
Copy link

Either fix the OSL code or change aiStandard to match.
Alternatively: clearly state that one or the other is not meant to be an implementation of this standard.

See also #11.
@iliyang
Copy link
Contributor

iliyang commented Oct 27, 2020

Hi @virtualritz. The OSL reference implementation included in this repository is incomplete, partly due to the limited list of closures bundled with OSL. Ideally, all necessary closures to reproduce Standard Surface would be built-in, and we are hoping that those will become part of OSL soon. In the mean time, we can at least provide a complete implementation that assumes the closures are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@virtualritz @iliyang