Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad cookie default configuration disabling cache when not needed #106

Open
msalaj opened this issue Jun 24, 2023 · 0 comments
Open

Bad cookie default configuration disabling cache when not needed #106

msalaj opened this issue Jun 24, 2023 · 0 comments

Comments

@msalaj
Copy link

msalaj commented Jun 24, 2023

there are common cookies that will disable batcache because there is bad default cookie configuration. Currently, all cookies that begin with wp will cause cache to bypass. But there are no wp cookies I am aware of that should disable cache. But there are cookies like wp_lang or wpl_* from wpeka gdpr plugin, that will cause batcache to not cache the page. I run into this issue in Pressable hosting sertvice, where they are using batcache for their distributed Edge Cache implementation, but there is no way to change configuration of it

I made pull request with my proposed changes in default behavior

#105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant