Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack : 404/400 requests to json api when Jetpack is disconnected. #37935

Open
mdbitz opened this issue Jun 18, 2024 · 0 comments
Open

My Jetpack : 404/400 requests to json api when Jetpack is disconnected. #37935

mdbitz opened this issue Jun 18, 2024 · 0 comments
Labels
[Focus] Performance [Package] My Jetpack [Platform] Atomic [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@mdbitz
Copy link
Contributor

mdbitz commented Jun 18, 2024

Impacted plugin

Jetpack

Quick summary

When Jetpack is activated but not connected the My Jetpack page is making unnecessary API calls repeatedly.

If no connection exists there should not be any api requests to load data. In addition the code needs to be hardened so that it recognizes 400 and 404 responses and does not attempt to retry the requests.

Steps to reproduce

  1. Install and Activate jetpack
  2. Visit the wp-admin
  3. open Dev Tools to the "network" tab
  4. Visit My Jetpack

image

A clear and concise description of what you expected to happen.

When Jetpack is activated but not connected we should not be making these api requests. At a minimum we should only be making them once.

What actually happened

4 requests are triggered that return 404/400 responses. These requests are retried twice for a total of 12 requests.

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Atomic, Self-hosted

Logs or notes

No response

@mdbitz mdbitz added [Type] Bug When a feature is broken and / or not performing as intended [Package] My Jetpack Needs triage Ticket needs to be triaged labels Jun 18, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Platform] Atomic [Pri] High labels Jun 18, 2024
@jeherve jeherve added Triaged [Focus] Performance and removed Needs triage Ticket needs to be triaged [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Performance [Package] My Jetpack [Platform] Atomic [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

2 participants