Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter: Pre-publish panel focussing on Newsletter component on Gutenberg trunk #37953

Open
coder-karen opened this issue Jun 19, 2024 · 0 comments
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@coder-karen
Copy link
Contributor

coder-karen commented Jun 19, 2024

Issue

Ordinarily when creating a post and clicking publish, I see that it is expected that the Newsletter component in the pre-publish panel expands (aria-expanded is set to true).

When testing with the Gutenberg Nightly plugin installed (Gutenberg trunk), if the Newsletter component was out of site initially then it will be brought in focus with the scroll moving down.

The reason this could be an issue is that the final 'publish' button is now out of site. This did cause me some confusion initially, so inevitably would do for others (though only on small screens) - once those changes (and if those changes) make their way into core.

Screenshot 2024-06-19 at 16 58 14

To replicate

  • On a site with the latest stable Jetpack version (or trunk), install the Gutenberg Nightly plugin
  • Create a new post, and ensure the screen height is reasonably small (around 600px for example)
  • When clicking publish, notice that the Newsletter component becomes visible, hiding the final 'Publish' button.
  • If you have subscriptions enabled (the above assumes the default, disabled), it appears that both the Access and Newsletter panels are auto-expanded and brought into focus.

What I'd expect to see

I would expect that even if the Newsletter panel is expanded, I'd still be able to see the Publish button

@coder-karen coder-karen added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jun 19, 2024
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Normal Triaged labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

2 participants