Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: allow classic themes to preview or edit modals #37980

Open
simison opened this issue Jun 21, 2024 · 0 comments
Open

Newsletters: allow classic themes to preview or edit modals #37980

simison opened this issue Jun 21, 2024 · 0 comments
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@simison
Copy link
Member

simison commented Jun 21, 2024

We allow customers to enable modals and few other things in classic themes, but since preview/editing happens in the template editor, we don't allow them to edit them:

Block themes:
Screenshot 2024-06-21 at 14 29 54

Classic themes:
image

We could however:

  • Explore allowing edit links if classic theme declares add_theme_support( 'block-template-parts' );
  • Add copy indicating that with more modern theme they could preview/edit the modals. Perhaps in a popover.
  • Add preview links which are just static links to the site, but with some URL attribute forcing the modals to show up even if they're disabled, e.g. ?jetpack-preview-welcome-overlay etc

Came up in p1718967449951009-slack-C052XEUUBL4

@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

1 participant