-
Notifications
You must be signed in to change notification settings - Fork 841
jetpack: More locking in CI coverage test #45902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR #45851 added some locking for Jetpack_Sync_Themes_Test. We also have some tests that are messing with a plugin, which can also wind up interfering with each other. Add locking for those too.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
|
|
||
| public function tear_down() { | ||
| if ( $this->the_plugin_lock ) { | ||
| $this->remove_the_plugin(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because it might throw and end a test early?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. The lock would get released anyway when the phpunit process exits, but it doesn't hurt to clean up earlier.
Closes MONOREP-218
Proposed changes:
PR #45851 added some locking for Jetpack_Sync_Themes_Test. We also have some tests that are messing with a plugin, which can also wind up interfering with each other. Add locking for those too.
Other information:
Jetpack product discussion
p1762964280572399/1762963867.449579-slack-C034JEXD1RD
Does this pull request change what data or activity we track or use?
No
Testing instructions: