Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve registration process #1202

Open
danjjohnson opened this issue Dec 1, 2015 · 6 comments
Open

Improve registration process #1202

danjjohnson opened this issue Dec 1, 2015 · 6 comments
Labels
[Pri] Normal Can wait for the next release [Type] Enhancement

Comments

@danjjohnson
Copy link
Contributor

danjjohnson commented Dec 1, 2015

When registering via My Courses, the registration process is different from the default WordPress process. You enter your chosen password on the page, and no confirmation email is sent.

We should use the default WordPress registration process here, where only the email address and username are entered, and an email is sent with a link to set your password.

Also, we should use the standard login form, to enable login via WordPress.com using Jetpack SSO. #3312 was created to handle this.

@bor0
Copy link
Member

bor0 commented Nov 11, 2016

@danjjohnson can we conclude the acceptance criteria for this item?

  1. Enable SSO logins (need to investigate the possibility of this)
  2. Users should be able to register by supplying Username and Email address only (and Email is sent with a password), as opposed to providing a password as well.

@bor0
Copy link
Member

bor0 commented Nov 11, 2016

Actually, on a second thought, I still don't understand how we can implement this.

We should use the default WordPress registration process here, where only the email address and username are entered, and an email is sent with a link to set your password.

If we send them an e-mail with a link to reset a password, we still have the problem in #1603, i.e. we can't redirect them to my-courses, unless we make another custom form to set passwords.

Another thing we can do is instead send them an e-mail with a link of the password generated for them, and log them automatically, in which case the purpose of that e-mail is to just let them know what their password is for future logins, and not to activate their account.

bor0 added a commit that referenced this issue Nov 11, 2016
@bor0
Copy link
Member

bor0 commented Nov 14, 2016

We discussed this with @danjjohnson internally, and here's what we decided:

  1. [PR Add password strength when registering. #1640] We will be adding a Password Strength option, as is done similarly here: screen_shot_2016-11-14_at_12 34 49
  2. [PR Update registration process #1636] We will be adding an option "Automatically generate user password"
  • If enabled, when users are going through the registration process they will not be able to set a password, and instead a randomly generated password will be mailed to them.
  • If disabled, they will have to set a password themselves.

bor0 added a commit that referenced this issue Nov 14, 2016
Details are discussed in the issue #1202, specifically [here](#1202 (comment)).
bor0 added a commit that referenced this issue Nov 14, 2016
Details are discussed in the issue #1202, specifically [here](#1202 (comment)).
@bor0 bor0 added the [Pri] Normal Can wait for the next release label Nov 14, 2016
bor0 added a commit that referenced this issue Nov 14, 2016
Details are discussed in the issue #1202, specifically [here](#1202 (comment)).
@lisaleague
Copy link

+1 for Automatically generate user password option

@pgk pgk added this to the 2.0 milestone Mar 13, 2017
@pgk pgk removed this from the Future Release milestone Mar 13, 2017
@donnapep donnapep changed the title Registration process Improve registration process Oct 16, 2017
@donnapep donnapep removed this from the 1.10.0 milestone Nov 21, 2017
@alexsanford
Copy link
Contributor

alexsanford commented May 11, 2020

Standardizing this should also allow for plugins to add features such as email verification when a user registers (although this is probably not needed if they need to use an email link to set their password anyway).

Related: 2943141-zen

@donnapep
Copy link
Collaborator

Separated out the standard login form to a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Can wait for the next release [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

7 participants