Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LM Modern - Make sidebar sticky #5912

Open
gikaragia opened this issue Oct 12, 2022 · 2 comments · May be fixed by #6304
Open

LM Modern - Make sidebar sticky #5912

gikaragia opened this issue Oct 12, 2022 · 2 comments · May be fixed by #6304
Assignees
@yscik

Comments

@gikaragia
Copy link
Contributor

gikaragia commented Oct 12, 2022 •
edited
Loading

Input from this comment: p6rkRX-4Bm-p2#comment-4915

The sidebar in modern should be sticky. Also in case there aren't many lessons the sidebar should be equal to video height.

Image
@yscik
Copy link
Contributor

yscik commented Oct 17, 2022

I think we can add a 'Fixed/Sticky' option to the Sidebar and Header blocks in the editor, so everyone can set it based on their preference, and we can cover more cases.

The sidebar should be equal to video height

The featured-video-size.js already does the math, we can update it to output the the height as a CSS variable to use for the sidebar.

This was referenced Oct 28, 2022
Open
Closed
@dadish dadish self-assigned this Dec 14, 2022
@dadish dadish linked a pull request Dec 15, 2022 that will close this issue
Open
@yscik yscik closed this as completed Jan 18, 2023
@gikaragia
Copy link
Contributor Author

Reopening this as I think that PR in sensei core is still open

@gikaragia gikaragia assigned yscik and unassigned dadish Jan 19, 2023
@yscik yscik reopened this Jan 19, 2023
@gikaragia gikaragia mentioned this issue Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yscik yscik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/lm sticky sidebar Automattic/sensei
3 participants
@yscik @dadish @gikaragia