From e945d55a8823b6704883b7a2ddffc91ab79c3a8c Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Sat, 1 Feb 2020 16:29:39 -0600 Subject: [PATCH 01/21] Include private lessons in course completion check --- includes/class-sensei-utils.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-utils.php b/includes/class-sensei-utils.php index 74bbb1004c..b8c3b1d32b 100755 --- a/includes/class-sensei-utils.php +++ b/includes/class-sensei-utils.php @@ -1610,7 +1610,7 @@ public static function user_complete_course( $course_id = 0, $user_id = 0, $trig ); // Grab all of this Courses' lessons, looping through each... - $lesson_ids = Sensei()->course->course_lessons( $course_id, 'publish', 'ids' ); + $lesson_ids = Sensei()->course->course_lessons( $course_id, array( 'publish', 'private' ), 'ids' ); $total_lessons = count( $lesson_ids ); // ...if course completion not set to 'passed', and all lessons are complete or graded, // ......then all lessons are 'passed' From bf415062ba4473a9d2d569b7322a42df9bc54fea Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Sat, 1 Feb 2020 16:33:43 -0600 Subject: [PATCH 02/21] Fix sniffer issues in current function --- includes/class-sensei-utils.php | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/includes/class-sensei-utils.php b/includes/class-sensei-utils.php index b8c3b1d32b..a3eebdd707 100755 --- a/includes/class-sensei-utils.php +++ b/includes/class-sensei-utils.php @@ -1587,9 +1587,10 @@ public static function has_started_course( $course_id = 0, $user_id = 0 ) { * and then updates the course metadata with that information. * * @since 1.7.0 - * @param integer $course_id Course ID - * @param integer $user_id User ID - * @return mixed boolean or comment_ID + * @param integer $course_id Course ID. + * @param integer $user_id User ID. + * @param bool $trigger_completion_action + * @return mixed boolean or comment_ID. */ public static function user_complete_course( $course_id = 0, $user_id = 0, $trigger_completion_action = true ) { global $wp_version; @@ -1602,7 +1603,8 @@ public static function user_complete_course( $course_id = 0, $user_id = 0, $trig $course_status = 'in-progress'; $course_metadata = array(); $course_completion = Sensei()->settings->settings['course_completion']; - $lessons_completed = $total_lessons = 0; + $lessons_completed = 0; + $total_lessons = 0; $lesson_status_args = array( 'user_id' => $user_id, 'status' => 'any', @@ -1622,11 +1624,11 @@ public static function user_complete_course( $course_id = 0, $user_id = 0, $trig // ...if all lessons 'passed' then update the course status to complete // The below checks if a lesson is fully completed, though maybe should be Utils::user_completed_lesson() $all_lesson_statuses = array(); - // In WordPress 4.1 get_comments() allows a single query to cover multiple comment_post_IDs + // In WordPress 4.1 get_comments() allows a single query to cover multiple comment_post_IDs. if ( version_compare( $wp_version, '4.1', '>=' ) ) { $lesson_status_args['post__in'] = $lesson_ids; $all_lesson_statuses = self::sensei_check_for_activity( $lesson_status_args, true ); - // Need to always return an array, even with only 1 item + // Need to always return an array, even with only 1 item. if ( ! is_array( $all_lesson_statuses ) ) { $all_lesson_statuses = array( $all_lesson_statuses ); } @@ -1636,18 +1638,18 @@ public static function user_complete_course( $course_id = 0, $user_id = 0, $trig foreach ( $lesson_ids as $lesson_id ) { $lesson_status_args['post_id'] = $lesson_id; $each_lesson_status = self::sensei_check_for_activity( $lesson_status_args, true ); - // Check for valid return before using + // Check for valid return before using. if ( ! empty( $each_lesson_status->comment_approved ) ) { $all_lesson_statuses[] = $each_lesson_status; } } } foreach ( $all_lesson_statuses as $lesson_status ) { - // If lessons are complete without needing quizzes to be passed + // If lessons are complete without needing quizzes to be passed. if ( 'passed' != $course_completion ) { // A user cannot 'complete' a course if a lesson... // ...is still in progress - // ...hasn't yet been graded + // ...hasn't yet been graded. $lesson_not_complete_stati = array( 'in-progress', 'ungraded' ); if ( ! in_array( $lesson_status->comment_approved, $lesson_not_complete_stati, true ) ) { $lessons_completed++; @@ -1663,14 +1665,14 @@ public static function user_complete_course( $course_id = 0, $user_id = 0, $trig $course_status = 'complete'; } - // Update meta data on how many lessons have been completed + // Update meta data on how many lessons have been completed. $course_metadata['complete'] = $lessons_completed; - // update the overall percentage of the course lessons complete (or graded) compared to 'in-progress' regardless of the above + // Update the overall percentage of the course lessons complete (or graded) compared to 'in-progress' regardless of the above. $course_metadata['percent'] = self::quotient_as_absolute_rounded_percentage( $lessons_completed, $total_lessons ); $activity_logged = self::update_course_status( $user_id, $course_id, $course_status, $course_metadata ); - // Allow further actions + // Allow further actions. if ( 'complete' == $course_status && true === $trigger_completion_action ) { do_action( 'sensei_user_course_end', $user_id, $course_id ); } From 705ad6eb419d09268166bc78aa6f055f851b3d27 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 16:51:10 -0500 Subject: [PATCH 03/21] 01. Course archive - fix lesson count --- includes/class-sensei-course.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/includes/class-sensei-course.php b/includes/class-sensei-course.php index 6fad7d5327..c254710c75 100755 --- a/includes/class-sensei-course.php +++ b/includes/class-sensei-course.php @@ -1198,12 +1198,18 @@ public function course_author_lesson_count( $author_id = 0, $course_id = 0 ) { */ public function course_lesson_count( $course_id = 0 ) { + // Only get private posts if user has proper capabilities. + $post_status = array( 'publish' ); + if ( current_user_can( 'read_private_posts' ) ) { + $post_status[] = 'private'; + } + $lesson_args = array( 'post_type' => 'lesson', 'posts_per_page' => -1, 'meta_key' => '_lesson_course', 'meta_value' => $course_id, - 'post_status' => 'publish', + 'post_status' => $post_status, 'suppress_filters' => 0, 'fields' => 'ids', // less data to retrieve ); From 0599aaa39a464273886b094ada154f0ef76a1ab3 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 17:14:15 -0500 Subject: [PATCH 04/21] 02. Single course - fix display private lessons --- includes/class-sensei-course.php | 8 +++++++- includes/class-sensei-modules.php | 7 ++++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/includes/class-sensei-course.php b/includes/class-sensei-course.php index c254710c75..1f2da0d8a7 100755 --- a/includes/class-sensei-course.php +++ b/includes/class-sensei-course.php @@ -2845,7 +2845,12 @@ public static function load_single_course_lessons_query() { return; } - $course_lessons_post_status = isset( $wp_query ) && $wp_query->is_preview() ? 'all' : 'publish'; + $course_lessons_post_status = isset( $wp_query ) && $wp_query->is_preview() ? 'all' : array( 'publish' ); + + // Only get private posts if user has proper capabilities. + if ( current_user_can( 'read_private_posts' ) && ! $wp_query->is_preview() ) { + $course_lessons_post_status[] = 'private'; + } $course_lesson_query_args = array( 'post_status' => $course_lessons_post_status, @@ -2892,6 +2897,7 @@ public static function load_single_course_lessons_query() { 'fields' => 'ids', 'meta_key' => '_lesson_course', 'meta_value' => intval( $course_id ), + 'post_status' => $course_lessons_post_status, ) ); if ( ! empty( $course_lesson_order ) ) { diff --git a/includes/class-sensei-modules.php b/includes/class-sensei-modules.php index 6b94e883a0..66ffe8172b 100644 --- a/includes/class-sensei-modules.php +++ b/includes/class-sensei-modules.php @@ -1623,7 +1623,12 @@ public function get_lessons_query( $course_id, $term_id ) { } - $course_lessons_post_status = isset( $wp_query ) && $wp_query->is_preview() ? 'all' : 'publish'; + $course_lessons_post_status = isset( $wp_query ) && $wp_query->is_preview() ? 'all' : array( 'publish' ); + + // Only get private posts if user has proper capabilities. + if ( current_user_can( 'read_private_posts' ) && ! $wp_query->is_preview() ) { + $course_lessons_post_status[] = 'private'; + } $args = array( 'post_type' => 'lesson', From 35733ba3ac2f209932405e446b6321e390072e78 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 17:35:22 -0500 Subject: [PATCH 05/21] 03. Private course - fix is_enrolled() function --- includes/enrolment/class-sensei-course-enrolment.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/enrolment/class-sensei-course-enrolment.php b/includes/enrolment/class-sensei-course-enrolment.php index 23884858a1..92d68e99ea 100644 --- a/includes/enrolment/class-sensei-course-enrolment.php +++ b/includes/enrolment/class-sensei-course-enrolment.php @@ -113,8 +113,8 @@ public function is_enrolled( $user_id, $check_cache = true ) { return $is_enrolled; } - // Users can only be enrolled in a published course. - if ( 'publish' !== get_post_status( $this->course_id ) ) { + // Users can only be enrolled in a published course. Or in a private one. + if ( ! in_array( get_post_status( $this->course_id ), array( 'publish', 'private' ) ) ) { return false; } From f23ddb8b582a0b27565459cdad63a0b3314caba2 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 17:48:41 -0500 Subject: [PATCH 06/21] 03. Private Course - fix sniffer issue --- includes/enrolment/class-sensei-course-enrolment.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/enrolment/class-sensei-course-enrolment.php b/includes/enrolment/class-sensei-course-enrolment.php index 92d68e99ea..c39a8399a5 100644 --- a/includes/enrolment/class-sensei-course-enrolment.php +++ b/includes/enrolment/class-sensei-course-enrolment.php @@ -114,7 +114,7 @@ public function is_enrolled( $user_id, $check_cache = true ) { } // Users can only be enrolled in a published course. Or in a private one. - if ( ! in_array( get_post_status( $this->course_id ), array( 'publish', 'private' ) ) ) { + if ( ! in_array( get_post_status( $this->course_id ), array( 'publish', 'private' ), true ) ) { return false; } From 77dfb749e8a17c5f1f4406ec074525c2ee6a9887 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 17:49:27 -0500 Subject: [PATCH 07/21] 04. Single course - fix lesson count --- includes/class-sensei-course.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-course.php b/includes/class-sensei-course.php index 128282769f..55f1ff3cdd 100755 --- a/includes/class-sensei-course.php +++ b/includes/class-sensei-course.php @@ -1096,7 +1096,7 @@ public function course_count( $post_status = 'publish' ) { * @param string $fields (default: 'all'). WP only allows 3 types, but we will limit it to only 'ids' or 'all' * @return array{ type WP_Post } $posts_array */ - public function course_lessons( $course_id = 0, $post_status = 'publish', $fields = 'all' ) { + public function course_lessons( $course_id = 0, $post_status = array( 'publish', 'private' ), $fields = 'all' ) { if ( is_a( $course_id, 'WP_Post' ) ) { $course_id = $course_id->ID; From 052c056c12f04ca3def247a30d55abccf8ff9f63 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 22:47:58 -0500 Subject: [PATCH 08/21] 05. My courses - fix private lessons not appearing --- includes/shortcodes/class-sensei-shortcode-courses.php | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/shortcodes/class-sensei-shortcode-courses.php b/includes/shortcodes/class-sensei-shortcode-courses.php index cc98bf3cfb..4bb091bff0 100644 --- a/includes/shortcodes/class-sensei-shortcode-courses.php +++ b/includes/shortcodes/class-sensei-shortcode-courses.php @@ -118,6 +118,7 @@ protected function setup_course_query() { 'orderby' => $this->orderby, 'order' => $this->order, 'posts_per_page' => $this->number, + 'post_status' => array( 'publish', 'private' ), ); From 22d7d6a76fb12be3994277be94cf95efb3682ab2 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 22:54:56 -0500 Subject: [PATCH 09/21] 06. Single course - fix completion status not working in private courses --- includes/class-sensei-utils.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-utils.php b/includes/class-sensei-utils.php index 92510ad6e7..b4c694a26c 100755 --- a/includes/class-sensei-utils.php +++ b/includes/class-sensei-utils.php @@ -1523,7 +1523,7 @@ public static function user_complete_course( $course_id = 0, $user_id = 0, $trig 'type' => 'sensei_lesson_status', /* FIELD SIZE 20 */ ); - // Grab all of this Courses' lessons, looping through each... + // Grab all of this Courses' lessons (publish and private status), looping through each... $lesson_ids = Sensei()->course->course_lessons( $course_id, array( 'publish', 'private' ), 'ids' ); $total_lessons = count( $lesson_ids ); // ...if course completion not set to 'passed', and all lessons are complete or graded, From bc236c5d39c33f8afd339a5dac705235ce3455e8 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 22:58:48 -0500 Subject: [PATCH 10/21] 07. Grading - fix dropdown not including private lessons --- includes/class-sensei-grading.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-grading.php b/includes/class-sensei-grading.php index 0e8dbbf546..69161c3099 100755 --- a/includes/class-sensei-grading.php +++ b/includes/class-sensei-grading.php @@ -572,7 +572,7 @@ public function lessons_drop_down_html( $course_id = 0, $selected_lesson_id = 0 'order' => 'ASC', 'meta_key' => '_lesson_course', 'meta_value' => $course_id, - 'post_status' => 'publish', + 'post_status' => array( 'publish', 'private' ), 'suppress_filters' => 0, 'fields' => 'ids', ); From d71fc300506826c0421b32af9eb7556617f1cec8 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 23:04:57 -0500 Subject: [PATCH 11/21] 08. Learners Management - fix table does not include private courses --- includes/admin/class-sensei-learners-main.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/admin/class-sensei-learners-main.php b/includes/admin/class-sensei-learners-main.php index f31b9c14b9..f2af26582a 100644 --- a/includes/admin/class-sensei-learners-main.php +++ b/includes/admin/class-sensei-learners-main.php @@ -672,7 +672,7 @@ private function get_edit_start_date_form( $user_activity, $post_id, $post_type, private function get_courses( $args ) { $course_args = array( 'post_type' => 'course', - 'post_status' => 'publish', + 'post_status' => array( 'publish', 'private' ), 'posts_per_page' => $args['per_page'], 'offset' => $args['offset'], 'orderby' => $args['orderby'], From 4cc55d63300825ea0dbf996cb97fa497d0f585db Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 23:06:50 -0500 Subject: [PATCH 12/21] 09. Learners Management - fix table does not include private lessons --- includes/admin/class-sensei-learners-main.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/admin/class-sensei-learners-main.php b/includes/admin/class-sensei-learners-main.php index f2af26582a..55ea61c8e0 100644 --- a/includes/admin/class-sensei-learners-main.php +++ b/includes/admin/class-sensei-learners-main.php @@ -709,7 +709,7 @@ private function get_courses( $args ) { private function get_lessons( $args ) { $lesson_args = array( 'post_type' => 'lesson', - 'post_status' => 'publish', + 'post_status' => array( 'publish', 'private' ), 'posts_per_page' => $args['per_page'], 'offset' => $args['offset'], 'orderby' => $args['orderby'], From 8b31c65f32d584caead3d60a29aebb8713dc34ba Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 23:09:58 -0500 Subject: [PATCH 13/21] 10. Dashboard - fix at a glance widget --- includes/class-sensei-admin.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/includes/class-sensei-admin.php b/includes/class-sensei-admin.php index a2de35e710..747cd8d9a5 100755 --- a/includes/class-sensei-admin.php +++ b/includes/class-sensei-admin.php @@ -963,11 +963,12 @@ public function glance_items( $items = array() ) { if ( $num_posts ) { - $published = intval( $num_posts->publish ); - $post_type = get_post_type_object( $type ); + $published = intval( $num_posts->publish ); + $published_as_private = intval( $num_posts->private ); + $post_type = get_post_type_object( $type ); $text = '%s ' . $post_type->labels->singular_name; - $text = sprintf( $text, number_format_i18n( $published ) ); + $text = sprintf( $text, number_format_i18n( $published + $published_as_private ) ); if ( current_user_can( $post_type->cap->edit_posts ) ) { $items[] = sprintf( '%2$s', $type, $text ) . "\n"; From cc70f3a0112b037b52a7fc616174cba5fa72e444 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 23:16:34 -0500 Subject: [PATCH 14/21] 11. New Lesson - fix lesson prerequisite dropdown --- includes/class-sensei-lesson.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-lesson.php b/includes/class-sensei-lesson.php index 8029f94b02..ff2586c2e4 100755 --- a/includes/class-sensei-lesson.php +++ b/includes/class-sensei-lesson.php @@ -285,7 +285,7 @@ public function lesson_prerequisite_meta_box_content() { 'order' => 'ASC', 'exclude' => $post->ID, 'suppress_filters' => 0, - 'post_status' => [ 'publish', 'draft' ], + 'post_status' => array( 'publish', 'draft', 'private' ), ); $posts_array = get_posts( $post_args ); // Build the HTML to Output From b383d9722d8615ffcc8fcbbe7702b3d4574b202a Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Thu, 23 Apr 2020 23:20:11 -0500 Subject: [PATCH 15/21] 12. New Course - fix course prerequisite dropdown --- includes/class-sensei-course.php | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/class-sensei-course.php b/includes/class-sensei-course.php index 55f1ff3cdd..bd62d267b2 100755 --- a/includes/class-sensei-course.php +++ b/includes/class-sensei-course.php @@ -322,6 +322,7 @@ public function course_prerequisite_meta_box_content() { 'order' => 'DESC', 'exclude' => $post->ID, 'suppress_filters' => 0, + 'post_status' => array( 'publish', 'private' ), ); $posts_array = get_posts( $post_args ); From eeb9657e7c16177761372c96bad5c03927e47c6f Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Fri, 24 Apr 2020 00:16:17 -0500 Subject: [PATCH 16/21] 13. New Lesson - fix add lesson to course order --- includes/class-sensei-lesson.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-lesson.php b/includes/class-sensei-lesson.php index ff2586c2e4..bdf1af07e6 100755 --- a/includes/class-sensei-lesson.php +++ b/includes/class-sensei-lesson.php @@ -438,7 +438,7 @@ public function add_lesson_to_course_order( $lesson_id = 0 ) { return; } - if ( ! in_array( get_post_status( $lesson_id ), array( 'publish', 'future', 'pending' ), true ) ) { + if ( ! in_array( get_post_status( $lesson_id ), array( 'publish', 'future', 'pending', 'private' ), true ) ) { return; } From b6f04e8f4862c7ee471e2368497e306fb54cf662 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Fri, 24 Apr 2020 00:20:58 -0500 Subject: [PATCH 17/21] 14. Single course module - fix error in module progress calculation --- includes/class-sensei-modules.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/includes/class-sensei-modules.php b/includes/class-sensei-modules.php index d1e6524eaf..3e837fdcdd 100644 --- a/includes/class-sensei-modules.php +++ b/includes/class-sensei-modules.php @@ -980,9 +980,14 @@ public function get_user_module_progress( $module_id = 0, $course_id = 0, $user_ */ public function calculate_user_module_progress( $user_id = 0, $module_id = 0, $course_id = 0 ) { + $post_status = array( 'publish' ); + if ( user_can( $user_id, 'read_private_posts' ) ) { + $post_status[] = 'private'; + } + $args = array( 'post_type' => 'lesson', - 'post_status' => 'publish', + 'post_status' => $post_status, 'posts_per_page' => -1, 'tax_query' => array( array( From e19e69d8bdcac5e54b0fba7f48e8efd7694fc06a Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Fri, 24 Apr 2020 00:24:42 -0500 Subject: [PATCH 18/21] 15. Modules - fix table not displaying private lessons --- includes/class-sensei-modules.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-modules.php b/includes/class-sensei-modules.php index 3e837fdcdd..09f64ed908 100644 --- a/includes/class-sensei-modules.php +++ b/includes/class-sensei-modules.php @@ -1289,7 +1289,7 @@ public function taxonomy_column_headings( $columns ) { public function taxonomy_column_content( $column_data, $column_name, $term_id ) { $args = array( - 'post_status' => 'publish', + 'post_status' => array( 'publish', 'private' ), 'posts_per_page' => -1, 'tax_query' => array( array( From 459d059da44ba90eded9e2455df66ab644256207 Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Fri, 24 Apr 2020 00:26:54 -0500 Subject: [PATCH 19/21] 16. Authors - fix lesson count --- includes/class-sensei-course.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-course.php b/includes/class-sensei-course.php index bd62d267b2..dc9b64d8fb 100755 --- a/includes/class-sensei-course.php +++ b/includes/class-sensei-course.php @@ -1244,7 +1244,7 @@ public function course_author_lesson_count( $author_id = 0, $course_id = 0 ) { 'author' => $author_id, 'meta_key' => '_lesson_course', 'meta_value' => $course_id, - 'post_status' => 'publish', + 'post_status' => array( 'publish', 'private' ), 'suppress_filters' => 0, 'fields' => 'ids', // less data to retrieve ); From 53f733852926b863ba5aa6a00d8b27db130a765f Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Fri, 24 Apr 2020 00:28:25 -0500 Subject: [PATCH 20/21] 17. Teacher Notification - fix error on sending notification --- includes/class-sensei-teacher.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-teacher.php b/includes/class-sensei-teacher.php index 6308e5e486..9bdb64bfcc 100755 --- a/includes/class-sensei-teacher.php +++ b/includes/class-sensei-teacher.php @@ -882,7 +882,7 @@ public function notify_admin_teacher_course_creation( $new_status, $old_status, $course_id = $post->ID; - if ( 'publish' == $old_status || 'course' != get_post_type( $course_id ) || 'auto-draft' == get_post_status( $course_id ) + if ( 'publish' == $old_status || 'private' == $old_status || 'course' != get_post_type( $course_id ) || 'auto-draft' == get_post_status( $course_id ) || 'trash' == get_post_status( $course_id ) || 'draft' == get_post_status( $course_id ) ) { return false; From ff62493397c32f482e3f8d7448dcdc50c541f55d Mon Sep 17 00:00:00 2001 From: JuanchoPestana Date: Fri, 24 Apr 2020 00:36:40 -0500 Subject: [PATCH 21/21] 17. Teacher Notification - fix sniffer issue --- includes/class-sensei-teacher.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-sensei-teacher.php b/includes/class-sensei-teacher.php index 9bdb64bfcc..ea305bb5cf 100755 --- a/includes/class-sensei-teacher.php +++ b/includes/class-sensei-teacher.php @@ -882,7 +882,7 @@ public function notify_admin_teacher_course_creation( $new_status, $old_status, $course_id = $post->ID; - if ( 'publish' == $old_status || 'private' == $old_status || 'course' != get_post_type( $course_id ) || 'auto-draft' == get_post_status( $course_id ) + if ( 'publish' == $old_status || 'private' === $old_status || 'course' != get_post_type( $course_id ) || 'auto-draft' == get_post_status( $course_id ) || 'trash' == get_post_status( $course_id ) || 'draft' == get_post_status( $course_id ) ) { return false;