Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: Visiting a plugin in the global plugins view results in a hidden update routine #92241

Closed
ebinnion opened this issue Jul 1, 2024 · 3 comments
Labels
Needs triage Ticket needs to be triaged [Type] Bug

Comments

@ebinnion
Copy link
Contributor

ebinnion commented Jul 1, 2024

Quick summary

If I visit a specific plugin in the global plugins view, I then see a set of notices that indicate plugins are being updated followed by some other notices that indicate success or error.

CleanShot 2024-07-01 at 09 40 11@2x
CleanShot 2024-07-01 at 09 40 29@2x
CleanShot 2024-07-01 at 09 44 10@2x

There are some issues with this:

  1. It's unclear to me what's getting updated. Does this update routine only happen when I view Calypso? Or, does it happen other times?
  2. The notice that plugins are updating seems to trigger from the moment that I hit the page. Even before the site is loaded. See second screenshot above.
  3. Even when I don't have plugins on a site, the notice says it's updating the site. 3rd screenshot above ... I don't use WP Bakery anywhere to my knowledge.

Overall, the UX here feels off and I don't believe that it's been updated since we've explored the a4a panel, scheduled plugin updates, core auto-updates, etc. If I recall, the first versions of this UX were very much driven by Calypso with API calls. Is that still the case?

Steps to reproduce

  1. Go to global plugins views at https://wordpress.com/plugins.
  2. Click a single plugin.
  3. See that auto-updates notice is appearing.

What you expected to happen

I don't think that auto-updating as a user visits a UI is the right UX nor do I think a notice is the right UI.

What actually happened

A notice appeared that confused me.

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@lupus2k
Copy link
Contributor

lupus2k commented Jul 2, 2024

I was able to reproduce an error message, but not the same as the first screenshot:
image

I tried to reproduce the "an error occurred while updating" error without success.

The second message is caused by the Jetpack beta / Jetpack dev / Mu WPcom Plugin. Those plugins fail to update, and, apparently, it should not appear in the site plugins, like in the /plugins/:site endpoints.

I added more details here: p1719866457103339-slack-CDLH4C1UZ

@lupus2k
Copy link
Contributor

lupus2k commented Jul 11, 2024

Error messages were fixed here and here, about the plugins not updating, I created a new issue here

@davemart-in
Copy link
Contributor

Closing this out since it's been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage Ticket needs to be triaged [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants