-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login Assistance: Update the "migrate CTA when login fails" experiment #92245
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~43 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~78 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~79 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I didn't know how to test the unknown_user
case at all. I presume that you tested that bit?
Thanks, Donna!
Yep, that one should be fine if you saw the notice while testing with an unknown user. 👍 |
…riment (#93146) * Revert "Login Assistance: Update the "migrate CTA when login fails" experiment (#92245)" This reverts commit e713d16. * Revert "Login: Fix migrate notice events not triggering (#91607)" This reverts commit 9daba74. * Revert "Login Assistance: Show migrate CTA when login fails (#91188)" This reverts commit 0f754b1. * Keep the `getCookies` function
…riment (#93146) * Revert "Login Assistance: Update the "migrate CTA when login fails" experiment (#92245)" This reverts commit e713d16. * Revert "Login: Fix migrate notice events not triggering (#91607)" This reverts commit 9daba74. * Revert "Login Assistance: Show migrate CTA when login fails (#91188)" This reverts commit 0f754b1. * Keep the `getCookies` function
Resolves #92246
Proposed Changes
recognized_logins
cookie to detect existing users and don't show them the CTA.unknown_user
. This fixes a bug where the CTA is displayed when an empty form is submitted and thecalypso_login_block_login_form_get_auth_type_failure
(error_code: unknown_user
) experiment exposure event was fired previously.Why are these changes being made?
Testing Instructions
recognized_logins
cookie with some value to the calypso.localhost domain.recognized_logins
cookie, setup your local Calypso to run on wordpress.com (where the cookie is set by the public api) following this guide: PCYsg-5YE-p2. Or change the domain where the cookie is set on your sandbox.rfdJOj.mp4
Pre-merge Checklist