-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add January Bump card to My Home screen #97692
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
||
@media (min-width: ($break-wide + 1)) { | ||
margin: 0 32px 32px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~231 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~14 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17070611 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
b1cae92
to
2a88e3a
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@claudiucelfilip It works but I'm seeing the same version pre/post launch: I also can't find the two versions in the code. Do I miss anything? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To close the loop here, @claudiucelfilip and I chatted and clarified the question above. I thought there were different CTA colors, but that's just the theme color. What's needed to be check is the layout having the pre-launch checklist or not.
In that sense, it works and LGTM :)
Sorry for the confusion. The screenshots were made from sites with different color palettes. |
Confirming that it has. The initial screenshots were from a site where they were hidden. |
2a88e3a
to
f7f8950
Compare
Related to #
Proposed Changes
This adds a task card for the January Bump promo.
More info: pdvytD-Uc-p2#comment-696
Testing Instructions
public-api.wordpress.com
Post Launch
Pre Launch
Pre-merge Checklist