Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add January Bump card to My Home screen #97692

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented Dec 20, 2024

Related to #

Proposed Changes

This adds a task card for the January Bump promo.

More info: pdvytD-Uc-p2#comment-696

Testing Instructions

  • Sandbox public-api.wordpress.com
  • Apply 169188-ghe-Automattic/wpcom
  • Go to the My Home screen for a pre and post blogs
  • You should see the January Bump card

Post Launch

Screenshot 2024-12-20 at 13 28 46

Pre Launch

  • Ensure the pre-launch checklist is visible beneath the card
Screenshot 2024-12-23 at 14 15 13

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@claudiucelfilip claudiucelfilip self-assigned this Dec 20, 2024
Comment on lines -311 to -314

@media (min-width: ($break-wide + 1)) {
margin: 0 32px 32px;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this because this was causing the top card margin to be removed on larger screens:
Screenshot 2024-12-20 at 13 29 37
Screenshot 2024-12-20 at 13 29 31
Screenshot 2024-12-20 at 13 29 27
Screenshot 2024-12-20 at 13 29 23

@claudiucelfilip claudiucelfilip requested review from southp, sixhours and a team December 20, 2024 11:42
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 20, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~231 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
home                                  +646 B  (+0.0%)     +231 B  (+0.0%)
reader                                 +38 B  (+0.0%)      +15 B  (+0.0%)
plugins                                +38 B  (+0.0%)      +15 B  (+0.0%)
jetpack-cloud-plugin-management        +38 B  (+0.0%)      +15 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~14 bytes added 📈 [gzipped])

name                                                parsed_size           gzip_size
async-load-calypso-blocks-jitm-templates-home-task        +38 B  (+0.1%)      +14 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@claudiucelfilip claudiucelfilip added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 20, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 20, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17070611

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 23, 2024

Translation for this Pull Request has now been finished.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/january-bump-card on your sandbox.

@southp
Copy link
Contributor

southp commented Dec 23, 2024

@claudiucelfilip It works but I'm seeing the same version pre/post launch:

CleanShot 2024-12-23 at 18 09 51@2x

I also can't find the two versions in the code. Do I miss anything?

Copy link
Contributor

@southp southp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To close the loop here, @claudiucelfilip and I chatted and clarified the question above. I thought there were different CTA colors, but that's just the theme color. What's needed to be check is the layout having the pre-launch checklist or not.

In that sense, it works and LGTM :)

@claudiucelfilip
Copy link
Contributor Author

I also can't find the two versions in the code. Do I miss anything?

Sorry for the confusion. The screenshots were made from sites with different color palettes.
I updated the pre-launch one with matching colors.

@claudiucelfilip
Copy link
Contributor Author

What's needed to be check is the layout having the pre-launch checklist or not.

Confirming that it has. The initial screenshots were from a site where they were hidden.
Updated Post Lauch screenshot with pre-launch checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants