Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency to pricing page and checkout page view tracks #97716

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

CodeyGuyDylan
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan commented Dec 20, 2024

Proposed Changes

  • Add currency prop to page views on the pricing page and checkout

Why are these changes being made?

We don't currently have currency tracked on these page views

Testing Instructions

  1. Open the Calypso Blue live link
  2. Go to /checkout/jetpack/jetpack_complete
  3. In tracks vigilante, or wherever you look at tracks, find the calypso_checkout_page_view event and ensure the currency prop is present
    Screenshot 2024-12-20 at 12 01 03 PM
  4. Open the Calypso Green live link
  5. Go to /pricing
  6. Find the calypso_jetpack_pricing_page_visit event and ensure currency is tracked
    Screenshot 2024-12-20 at 12 03 00 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@CodeyGuyDylan CodeyGuyDylan requested a review from a team as a code owner December 20, 2024 18:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 20, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/currency-to-pricing-page-and-checkout-page-views on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~56 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
plans                        +95 B  (+0.0%)      +47 B  (+0.0%)
jetpack-connect              +95 B  (+0.0%)      +47 B  (+0.0%)
jetpack-cloud-pricing        +95 B  (+0.0%)      +47 B  (+0.0%)
checkout                     +26 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~9 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal             +26 B  (+0.0%)       +9 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal        +26 B  (+0.0%)       +9 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to the checkout part of this! I can't speak to the Jetpack plans page part.

Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works good. Code looks good.
LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants