Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make WP_CLDR a singleton? #93

Open
jblz opened this issue Nov 21, 2017 · 0 comments
Open

Should we make WP_CLDR a singleton? #93

jblz opened this issue Nov 21, 2017 · 0 comments
Labels

Comments

@jblz
Copy link
Member

jblz commented Nov 21, 2017

Repeatedly creating a new instance (for repeated lookups, etc.) is an anti-pattern because of the work done during initialization. Even if we use a cache, it's a pretty big hit to do this multiple times per request.

A singleton pattern (forcing use of a static get_instance() method by default) would work around this.

@jblz jblz added the question label Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant