Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scenario_selector: rendering in dark mode #2074

Closed
1 of 4 tasks
FabienLelaquais opened this issue Oct 16, 2024 · 11 comments
Closed
1 of 4 tasks

scenario_selector: rendering in dark mode #2074

FabienLelaquais opened this issue Oct 16, 2024 · 11 comments
Assignees
Labels
💥Malfunction Addresses an identified problem. 🟩 Priority: Low Low priority and doesn't need to be rushed

Comments

@FabienLelaquais
Copy link
Member

FabienLelaquais commented Oct 16, 2024

What went wrong? 🤔

This is a screenshot showing a scenario selector control in dark mode:
image

Note that one of the toolbar buttons is black, as are all the 'edit' buttons.

Also, the search button in the toolbar does not have a tooltip, contrary to his two neighbors. I'm just sayin'.

Expected Behavior

All button icons should turn to a bright color.

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%.
  • Create related issue in taipy-doc for documentation and Release Notes.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@FabienLelaquais FabienLelaquais added 💥Malfunction Addresses an identified problem. 🟩 Priority: Low Low priority and doesn't need to be rushed labels Oct 16, 2024
@saumy-sh
Copy link

Hey I would very much like to work on this issue. Can you assign it to me?

@aksbalaguru
Copy link

Hey I would like to contribute my knowledge to help fix this issue. Could you please assign this issue to me?

@FredLL-Avaiga FredLL-Avaiga self-assigned this Oct 16, 2024
@FredLL-Avaiga
Copy link
Member

FredLL-Avaiga commented Oct 16, 2024

With Stylekit changes ?
By default, it renders as
image

@FabienLelaquais
Copy link
Member Author

@saumy-sh and @aksbalaguru
Please hold on a little bit.

This issue was just created and has not been qualified whatsoever.
We will keep you posted.
Thanks

@saumy-sh
Copy link

Okay sure!

@saumy-sh
Copy link

Is there any update on it? Will we be assigned this issue?

@FredLL-Avaiga
Copy link
Member

Is there any update on it? Will we be assigned this issue?

I don't think this issue is opened to contributors yet

@saumy-sh
Copy link

So this issue isn't available under hacktoberfest for contribution right?

@FredLL-Avaiga
Copy link
Member

not now anyway

@jrobinAV
Copy link
Member

I was not able to reproduce the issue.

@jrobinAV
Copy link
Member

Not reproducible.

@jrobinAV jrobinAV closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥Malfunction Addresses an identified problem. 🟩 Priority: Low Low priority and doesn't need to be rushed
Projects
None yet
Development

No branches or pull requests

5 participants