Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG] Height property on chat control disables auto-scroll #2111

Closed
1 of 7 tasks
AlexandreSajus opened this issue Oct 21, 2024 · 5 comments
Closed
1 of 7 tasks
Assignees
Labels
🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community 💥Malfunction Addresses an identified problem. 🟧 Priority: High Must be addressed as soon

Comments

@AlexandreSajus
Copy link
Contributor

AlexandreSajus commented Oct 21, 2024

What went wrong? 🤔

Setting the height property on a chat control will disable the feature where the chat auto-scrolls down when new messages appear.

Expected Behavior

The auto-scroll feature should function even when height is set

Steps to Reproduce Issue

Run this code and type a bunch of messages until the chat is filled with messages:

from taipy.gui import Gui
import taipy.gui.builder as tgb

messages = []


def evaluate(state, var_name: str, payload: dict):
    state.messages.append(
        [10, "The MP5 is pretty fun to shoot actually, virtually no recoil", "Robot"]
    )
    state.messages = state.messages


with tgb.Page() as page_home:
    tgb.chat(
        messages="{messages}",
        on_action=evaluate,
        height="80vh",
    )

gui = Gui(page=page_home)
gui.run()

The chat will not scroll down for the new messages
image

Removing the height property solves the issue

Browsers

Chrome

OS

Windows

Version of Taipy

4.0.0

Acceptance Criteria

  • A unit test reproducing the bug is added.
  • Any new code is covered by a unit tested.
  • Check code coverage is at least 90%.
  • The bug reporter validated the fix.
  • Related issue(s) in taipy-doc are created for documentation and Release Notes are updated.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@AlexandreSajus AlexandreSajus added 🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟨 Priority: Medium Not blocking but should be addressed labels Oct 21, 2024
@TSP06
Copy link

TSP06 commented Oct 22, 2024

@AlexandreSajus would like to take this up can you also label it hacktoberfest

@AlexandreSajus AlexandreSajus added 🟥 Priority: Critical Must be addressed as soon as possible and removed 🟨 Priority: Medium Not blocking but should be addressed labels Oct 28, 2024
@AlexandreSajus
Copy link
Contributor Author

AlexandreSajus commented Oct 28, 2024

Putting this in High as a customer needs this in a dev release by the end of the year

@AlexandreSajus AlexandreSajus added 🟧 Priority: High Must be addressed as soon and removed 🟥 Priority: Critical Must be addressed as soon as possible labels Oct 28, 2024
@jrobinAV
Copy link
Member

jrobinAV commented Oct 30, 2024

@TSP06 This issue is not open to contribution yet. The Taipy maintainers team first needs to qualify the issue.

@jrobinAV jrobinAV added the 🆘 Help wanted Open to participation from the community label Nov 8, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Nov 18, 2024
@FredLL-Avaiga
Copy link
Member

When the chat is filled with message, you need to scroll down once and then the chat does auto-scroll

@AlexandreSajus
Copy link
Contributor Author

Fixed in 4.0.1
🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community 💥Malfunction Addresses an identified problem. 🟧 Priority: High Must be addressed as soon
Projects
None yet
Development

No branches or pull requests

4 participants