Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG] Chat control "new message" pop-up is weirdly placed and often inaccessible #2112

Open
1 of 7 tasks
AlexandreSajus opened this issue Oct 21, 2024 · 4 comments
Open
1 of 7 tasks
Labels
🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community 💥Malfunction Addresses an identified problem. 🟨 Priority: Medium Not blocking but should be addressed

Comments

@AlexandreSajus
Copy link
Contributor

AlexandreSajus commented Oct 21, 2024

What went wrong? 🤔

The chat control has a pop-up button saying "A new message is available" when you type a new message and the chat has not auto-scrolled down. Clicking on the button scrolls down to the last message. This pop-up is placed weirdly. For example, here, it overlaps with the chat control:

image

In another app, it was hidden behind the sidebar:
image

In another one, it's hidden off-screen:
image

Expected Behavior

This pop-up should probably be in a fixed position on the page, and it should be laid on top of anything else, like a notification (the ones spawned by gui.notify), for example

Steps to Reproduce Issue

Run this code and type many messages until they fill the screen. The pop-up will appear.

from taipy.gui import Gui
import taipy.gui.builder as tgb

messages = []


def evaluate(state, var_name: str, payload: dict):
    state.messages.append([10, "Loading...", "Robot"])
    state.messages = state.messages


with tgb.Page() as page_home:
    with tgb.layout(columns="1 3", columns__mobile="1"):
        tgb.chat(
            messages="{messages}",
            on_action=evaluate,
            height="80vh",
        )


if __name__ == "__main__":
    gui = Gui(page=page_home)
    gui.run()

Browsers

Chrome

OS

Windows

Version of Taipy

4.0.0

Acceptance Criteria

  • A unit test reproducing the bug is added.
  • Any new code is covered by a unit tested.
  • Check code coverage is at least 90%.
  • The bug reporter validated the fix.
  • Related issue(s) in taipy-doc are created for documentation and Release Notes are updated.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@AlexandreSajus AlexandreSajus added 🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟨 Priority: Medium Not blocking but should be addressed labels Oct 21, 2024
@sahilborse
Copy link

/attempt#2112 please assign me this issue

@FlorianJacta
Copy link
Member

@sahilborse You are also assigned here

Copy link
Contributor

github-actions bot commented Nov 8, 2024

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 8, 2024
Copy link
Contributor

This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 22, 2024
@jrobinAV jrobinAV added the 🆘 Help wanted Open to participation from the community label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community 💥Malfunction Addresses an identified problem. 🟨 Priority: Medium Not blocking but should be addressed
Projects
None yet
Development

No branches or pull requests

4 participants