Sys 4061 treasury spend tracks #412
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-cholakov
requested review from
nahuseyoum,
fluorostani and
thadouk
as code owners
ivan-cholakov
force-pushed
the
SYS-4061-treasury-spend-tracks
branch
from
530fec6
to
2d76e35
Compare
nahuseyoum
reviewed
Jun 4, 2024
| @@ -39,7 +39,16 @@ const APP_WHITELISTED_CALLER: Curve = | |||
| const SUP_WHITELISTED_CALLER: Curve = | |||
| Curve::make_reciprocal(1, 28, percent(20), percent(5), percent(50)); | |||
|
|
|||
| const TRACKS_DATA: [(u16, pallet_referenda::TrackInfo<Balance, BlockNumber>); 5] = [ | |||
| const APP_SMALL_SPENDER: Curve = Curve::make_linear(17, 28, percent(50), percent(100)); | |||
There was a problem hiding this comment.
Are these similar to Polkadot?
There was a problem hiding this comment.
yes, exactly the same
| @@ -72,4 +80,45 @@ pub mod pallet_custom_origins { | |||
| () => {} | |||
| } | |||
| decl_unit_ensures!(GeneralAdmin, ReferendumCanceller, ReferendumKiller, WhitelistedCaller,); | |||
|
|
|||
| macro_rules! decl_ensure { | |||
ivan-cholakov
force-pushed
the
SYS-4061-treasury-spend-tracks
branch
from
be65145
to
77577c6
Compare
ivan-cholakov
force-pushed
the
SYS-4061-treasury-spend-tracks
branch
from
a0cd896
to
1d4db66
Compare
ivan-cholakov
force-pushed
the
SYS-4061-treasury-spend-tracks
branch
from
ff17184
to
8401799
Compare
ivan-cholakov
force-pushed
the
SYS-4061-treasury-spend-tracks
branch
from
62c9a09
to
2da0e31
Compare
ivan-cholakov
force-pushed
the
SYS-4061-treasury-spend-tracks
branch
from
9505e3e
to
155a790
Compare
fluorostani
reviewed
Jul 22, 2024
Comment on lines
+118
to
+119
| SmallSpender = 1000 * AVT, | ||
| MediumSpender = 1000 * AVT, |
There was a problem hiding this comment.
Are these meant to be the same value?
There was a problem hiding this comment.
Good catch! Didn't notice it. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
TokenManagerpallet to check for the new originsType of change/Merge
🚨What type of change is this PR?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Further comments