Issues noticed when deploy single CoPilot instance in Azure

[jye-aviatrix]

Variable: controller_private_ip is required
Variable: controller_public_ip is not required with default value of "0.0.0.0"
Variable: private_mode default to false

Local variables

controller_ip = var.private_mode ? var.controller_private_ip : var.controller_public_ip

custom_data = <<EOF
#!/bin/bash
jq '.config.controllerIp="${local.controller_ip}" | .config.controllerPublicIp="${local.controller_ip}" | .config.isCluster=${var.is_cluster}' /etc/copilot/db.json > /etc/copilot/db.json.tmp
mv /etc/copilot/db.json.tmp /etc/copilot/db.json
EOF

When controller_private_ip is provided (as required), controller_public_ip and private_mode follows default value. This results the local.controller_ip to be "0.0.0.0", and when tried to logon to CoPilot it will fail to authenticate to Controller with ip: "0.0.0.0"

According to Reid Price:
"I believe this is still a bug though, copilot expects to use the private ip by default. it is happy to have both the private and public, and can work with just one or the other (except for private mode, where we need the private IP)"

I've performed a manual deployment of controller, during the first authentication, specified controller private IP only.
Then reviewed /etc/copilot/db.json.tmp /etc/copilot/db.json, it has following entries

Following fields are populated:

"controllerIp": "10.0.0.4",
"controllerPublicIp": "20.59.107.212",

Above bug is causing both fields been populated with "0.0.0.0"

"controllerIp": "0.0.0.0",
"controllerPublicIp": "0.0.0.0",