Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This mod breaks fueling system from hsk #229

Open
hadaev8 opened this issue Jun 29, 2021 · 4 comments
Open

This mod breaks fueling system from hsk #229

hadaev8 opened this issue Jun 29, 2021 · 4 comments

Comments

@hadaev8
Copy link

hadaev8 commented Jun 29, 2021

Can fueling changes be optional?

@Hazzer
Copy link
Collaborator

Hazzer commented Jun 29, 2021

Short answer: no.

Long answer: I don't like the idea of adding another "if" into code which will lead to another thing to ask during helping user session. This will also lead to unnecessary code obfuscation. I would rather know what is not working correctly, how should it work and eventually fix this. Another reason: making compatibility patches have the lower priority for me TBH.

@hadaev8
Copy link
Author

hadaev8 commented Jun 29, 2021

Okay, steps to reproduce:
Get hsk from here https://github.com/skyarkhangel/Hardcore-SK
Start new game
Build grill and cut any tree, pawn would fuel it.

Add prisoner labor (i tried both on the bottom of the list and before core sk mod).
Start new game, check any building with fuel like grill with any fuel like wood.

Job "fuel something" is broken, nothing in error log.

@Hazzer
Copy link
Collaborator

Hazzer commented Jun 29, 2021

Tbh most patches checks if vanilla results return false and if job responsible pawn is prisoner of colony. The only case when PL should affect refuel job is when you put prison labor zone on refualable building.

@hadaev8
Copy link
Author

hadaev8 commented Jun 29, 2021

Well, i didnt had any prisoners and special zones.
Maybe its not job, but something else.

Just tried to play with zones, added/removed home zone, prisoner zone, tested both colonists and prisoners.
No success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants