Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Memory Error when downloading longer videos (about an hour+) #123

Open
3 tasks done
Kroek opened this issue Jul 9, 2023 · 3 comments
Open
3 tasks done

Memory Error when downloading longer videos (about an hour+) #123

Kroek opened this issue Jul 9, 2023 · 3 comments
Labels
bug Something isn't working contributors appreciated help adding this functionality/feature

Comments

@Kroek
Copy link

Kroek commented Jul 9, 2023

Bug Description

Downloading longer videos results in a memory error

Actual behavior

the download fails when almost completed, resulting in this error message:

[19]ERROR | 15:31 || Unexpected error during sorting Single Post download;
Traceback (most recent call last):
File "fansly_downloader.py", line 1188, in
File "fansly_downloader.py", line 763, in sort_download
MemoryError

for this video, my computer's memory usage only went up to 60%

( If applicable, add screenshots to help explain your problem. )

Environment Information

  • Operating System: windows
  • Fansly Downloader Version: v0.4.1
  • Fansly Downloader Type: executable
  • Specific creators name: Boba Bitch

User Research

( fill [ ] with x, if you've already done said task )

I have done the following:

@Kroek Kroek added the needs triage issue needs to be validated label Jul 9, 2023
@Kroek Kroek changed the title [Replace with descriptive keypoint title] Memory Error when downloading longer videos (about an hour+) Jul 9, 2023
@Avnsx
Copy link
Owner

Avnsx commented Jul 9, 2023

How much RAM do you have?

Also before downloading that specific video, when enabling show_downloads, is the file ending printed into console .m3u8 or .mp4?

What post id is it?

Regardless, I do believe you that this is a valid bug. It's because the download_m3u8() function needs an actual binary stream wrapper, so that an entire video stops being held in memory during download and transcoding.

Kinda up to contributors, as this is a open source project and I'm a little fed up with it atm.

The only thing you personally can do is upgrading your RAM capacity to 32 GB+ or asking a friend with more RAM to download and transcode the video for you, or renting a VPS which has more RAM & a GPU installed and run Fansly Downloader on there :)

@Avnsx Avnsx added bug Something isn't working contributors appreciated help adding this functionality/feature and removed needs triage issue needs to be validated labels Jul 9, 2023
@Kroek
Copy link
Author

Kroek commented Jul 9, 2023

I have 16 GB of RAM

it's a .mp4 file

the id is 502723244063731712

that video is 56 minutes long.
I didn't notice it before, but i did successfully download a 2 and a half hour video so maybe it's not just the length?

I wouldn't be surprised if it is some problem with my system, it's nearly 10 years old by now

@Avnsx
Copy link
Owner

Avnsx commented Jul 10, 2023

maybe it's not just the length?

Yes there's multiple factors such as the videos Bitrate and Quality, which also influence its total Size.

Unfortunately the way fansly downloader is currently written in version 0.4.1, your hardware capabilities play a huge role.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working contributors appreciated help adding this functionality/feature
Projects
None yet
Development

No branches or pull requests

2 participants