Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As of now this module works only for Indian Pinocdes. Implement it for global pincodes. #2

Open
plxity opened this issue Feb 17, 2020 · 5 comments
Open

As of now this module works only for Indian Pinocdes. Implement it for global pincodes. #2

plxity opened this issue Feb 17, 2020 · 5 comments
Assignees
@abhushanaj
Labels
assigned gssoc20 hard help wanted Extra attention is needed

Comments

@plxity
Copy link
Collaborator

plxity commented Feb 17, 2020

No description provided.

@plxity plxity added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 17, 2020
@plxity plxity added hard and removed good first issue Good for newcomers labels Feb 20, 2020
@abhushanaj
Copy link
Contributor

@plxity this looks challenging I want to tackle it under GSSoC'20.

@Xtremilicious
Copy link
Contributor

Will surely want to have a shot at this!

@Xtremilicious
Copy link
Contributor

Xtremilicious commented Mar 6, 2020 •
edited
Loading

The problem is that ZIP/Postal Code formats are different for different regions. Like in India, a 6 digit code is used, for Iran, it's 10 and the US have 4 and 5 separated by a hyphen. Validations need to be changed accordingly.

The second part of the problem is the API call, currently, the API being used only has Indian postal codes, other API providers limit their usage. If the limitation is not a problem, I can do it. I can make trhe module work for more than just India. Let me know what you think:)

Xtremilicious added a commit to Xtremilicious/React-Pincode that referenced this issue Mar 6, 2020
@Xtremilicious
Removal Awesome-React-Modules#2
939d2b8
plxity pushed a commit that referenced this issue Mar 7, 2020
@Xtremilicious
Validation check for Pincodes (#29)
62bf9fd 
* zip-validation

* zip-validation

* API Parameters fixed

* Invalid Pin Code error message

* Removed package-lock.json and build folder

* Removal #2

* minor fixes
@siddhishree
Copy link
Contributor

Hey @plxity, I would like to take this up if this issue is still pending.

@plxity
Copy link
Collaborator Author

plxity commented Mar 13, 2020

@siddhishree How are you planning to work on this?

@abhushanaj abhushanaj mentioned this issue Mar 13, 2020
Closed
@abhushanaj abhushanaj mentioned this issue Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhushanaj abhushanaj

Labels
assigned gssoc20 hard help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementation for global pincodes
5 participants
@siddhishree @plxity @arpit9667 @Xtremilicious @abhushanaj