Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully-implement Typescript for plugin settings #14

Open
justlevine opened this issue Nov 28, 2022 · 0 comments
Open

Fully-implement Typescript for plugin settings #14

justlevine opened this issue Nov 28, 2022 · 0 comments
Labels
component: settings good first issue 🐣 Issue that doesn't require previous experience with the plugin status: confirmed 📍 The issue has been confirmed and reproduced. type: chore 🧹 No changes to production code.
Milestone
Future

Comments

@justlevine
Copy link
Member

What problem does this address?

Currently, the Plugin Settings screen use Typescript files to add a bit of extra type-safe linting, but its not implemented fully.

With the current state of WP's javascript eschewing traditional back-compat, and since using React for plugin settings is still a fairly uncommon pattern, the more type-safety to easily detect a break, the better.

What is your proposed solution?

All JS files should use Typescript, and ts linting should be added to the CI workflow.

What alternatives have you considered?

No response

Additional Context

No response
@justlevine justlevine added type: chore 🧹 No changes to production code. component: settings labels Nov 28, 2022
@justlevine justlevine added this to the Future milestone Nov 28, 2022
@justlevine justlevine added good first issue 🐣 Issue that doesn't require previous experience with the plugin status: confirmed 📍 The issue has been confirmed and reproduced. labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: settings good first issue 🐣 Issue that doesn't require previous experience with the plugin status: confirmed 📍 The issue has been confirmed and reproduced. type: chore 🧹 No changes to production code.
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@justlevine