From e04aeabc9013e292987cf0c1969b5176c74e9583 Mon Sep 17 00:00:00 2001 From: Cody Date: Fri, 15 Nov 2024 21:51:55 +0000 Subject: [PATCH] Respond to review --- .../execution_trace/execution_trace_usage_tracker.hpp | 1 - .../execution_trace/mega_execution_trace.hpp | 6 +++--- .../execution_trace/ultra_execution_trace.hpp | 2 +- .../barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/execution_trace_usage_tracker.hpp b/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/execution_trace_usage_tracker.hpp index 35bf5e9ec77..f5d3ddf5fd9 100644 --- a/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/execution_trace_usage_tracker.hpp +++ b/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/execution_trace_usage_tracker.hpp @@ -38,7 +38,6 @@ struct ExecutionTraceUsageTracker { } if (trace_settings.structure) { - info("yes trace structure"); fixed_sizes.set_fixed_block_sizes(trace_settings); } diff --git a/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/mega_execution_trace.hpp b/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/mega_execution_trace.hpp index e065a094e3a..a30a879142b 100644 --- a/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/mega_execution_trace.hpp +++ b/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/mega_execution_trace.hpp @@ -74,7 +74,7 @@ struct TraceSettings { uint32_t overflow_capacity = 0; }; -class MegaTraceBlock : public ExecutionTraceBlock { +class MegaTraceBlock : public ExecutionTraceBlock { using SelectorType = ExecutionTraceBlock::SelectorType; public: @@ -262,8 +262,8 @@ static constexpr TraceStructure SMALL_TEST_STRUCTURE{ .ecc_op = 1 << 14, .overflow = 0 }; /** - * @brief A minimal structuring specifically tailored to the medium complexity transaction for the Cli: MentIVC - * benchmark + * @brief A minimal structuring specifically tailored to the medium complexity transaction of the Client IVC + * benchmark. */ static constexpr TraceStructure CLIENT_IVC_BENCH_STRUCTURE{ .ecc_op = 1 << 10, .pub_inputs = 1 << 7, diff --git a/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/ultra_execution_trace.hpp b/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/ultra_execution_trace.hpp index 1b049e52350..92a2c5f8d6b 100644 --- a/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/ultra_execution_trace.hpp +++ b/barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/ultra_execution_trace.hpp @@ -39,7 +39,7 @@ template struct UltraTraceBlockData { bool operator==(const UltraTraceBlockData& other) const = default; }; -class UltraTraceBlock : public ExecutionTraceBlock { +class UltraTraceBlock : public ExecutionTraceBlock { using SelectorType = ExecutionTraceBlock::SelectorType; public: diff --git a/barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp b/barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp index ec35babb890..6e944cbff97 100644 --- a/barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp +++ b/barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp @@ -374,7 +374,7 @@ Accumulator ECCVMSetRelationImpl::compute_grand_product_denominator(const Al } /** - * @brief Expression for the StandardExecutionTracemetic gate. + * @brief Expression for the standard arithmetic gate. * @dbetails The relation is defined as C(in(X)...) = * (q_m * w_r * w_l) + (q_l * w_l) + (q_r * w_r) + (q_o * w_o) + q_c *