Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize encoding of note_type_id such that it occupies 7 bits. #10952

Open
benesjan opened this issue Dec 23, 2024 · 0 comments · May be fixed by #10968
Open

Optimize encoding of note_type_id such that it occupies 7 bits. #10952

benesjan opened this issue Dec 23, 2024 · 0 comments · May be fixed by #10968

Comments

@benesjan
Copy link
Contributor

benesjan commented Dec 23, 2024 •
edited
Loading

With this PR note_type_id now fits into 7 bits but the encoding is still 32 bytes. I didn't optimize the encoding because the to_be_bytes function will go away once we serialize to fields.

Note: Started work on this in #10899 but stopped as the whole to_be_bytes func will be most likely eventually nuked.
@crStiv crStiv linked a pull request Dec 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize note_type_id to use 7 bits crStiv/aztec-packages
1 participant
@benesjan