Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: MUL u128 is not properly constrained #9937

Open
Tracked by #3314
jeanmon opened this issue Nov 13, 2024 · 0 comments
Open
Tracked by #3314

AVM: MUL u128 is not properly constrained #9937

jeanmon opened this issue Nov 13, 2024 · 0 comments
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Nov 13, 2024

In alu.pil, the following variable
pol PRODUCT = a_lo * b_lo + (1 - u1_tag) * (LIMB_BITS_POW * partial_prod_lo + MAX_BITS_POW * (partial_prod_hi + a_hi * b_hi));
might overflow the field when operand type is u128. Namely, a_hi and b_hi are of size 64 bits and MAX_BITS_POW=2^128.
Note that modifications of PRODUCT might affect division relation as well.

@jeanmon jeanmon added the C-avm Component: AVM related tickets (aka public VM) label Nov 13, 2024
@jeanmon jeanmon added this to A3 Nov 13, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
Status: Todo
Development

No branches or pull requests

1 participant