Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure public input delta is correct if polynomial virtual size increases (not an issue in ClientIVC just isolated tests) #1158

Open
maramihali opened this issue Nov 26, 2024 · 0 comments

Comments

@maramihali
Copy link
Contributor

The correct construction of the public input delta in compute_public_input_delta depends on the agreement between the "domain_size" value used here and the "num_gates" value used in the construction of the sigma/id polynomials in compute_honk_style_permutation_lagrange_polynomials_from_mapping(). The former happens in the Decider PK constructor and the latter happens in oink so there's no issue unless something changes between those two steps (i.e. this shouldn't apply in the IVC setting because we've fully completed a key before expanding it to accommodate accumulation of a larger circuit). Still, it can come up in more isolated test and would be nice to find a way to systematically ensure these agree.

@maramihali maramihali changed the title Ensure public input delta is correct if polynomial virtual size increases Ensure public input delta is correct if polynomial virtual size increases (not an issue in ClientIVC just isolated tests) Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant