Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private link config for cosmos DB should be set to "sql" and not "cosmosdb" for private appservice deployments #2217

Open
ivanthelad opened this issue Dec 10, 2024 · 1 comment · May be fixed by #2226
Labels

Comments

@ivanthelad
Copy link

ivanthelad commented Dec 10, 2024

This issue is for a: (mark with an x)

- [ x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Deploy the demo with the following config

  • usePrivateEndpoint = true
  • deploymentTarget = appservice

This will result in failure as the groupid defined in the main.bicep is not a valid groupid for private endpoints
*https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/infra/main.bicep#L1097

List of group ids for databases

The privateendpoint config should look like this

      {
        groupId: 'sql'
        dnsZoneName: 'privatelink.documents.azure.com'
        resourceIds: (useAuthentication && useChatHistoryCosmos) ? [cosmosDb.outputs.resourceId] : []
      }

Any log messages given by the failure

Expected/desired behavior

Private link for cosmos db, SQL, is correctly setup
To fix this, modify the line https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/infra/main.bicep#L1097
to sql instead

      {
        groupId: 'sql'
        dnsZoneName: 'privatelink.documents.azure.com'
        resourceIds: (useAuthentication && useChatHistoryCosmos) ? [cosmosDb.outputs.resourceId] : []
      }

OS and Version?

N/A

azd version?

azd version 1.11.0

Versions

@ivanthelad ivanthelad changed the title Private link config for cosmos DB should be set to "sql" and not "cosmosdb" Private link config for cosmos DB should be set to "sql" and not "cosmosdb" for private appservice deployments Dec 10, 2024
@pamelafox pamelafox linked a pull request Dec 11, 2024 that will close this issue
@pamelafox
Copy link
Collaborator

Thanks for filing! I've made a PR here:
#2226

Please comment on that if that looks good.

@pamelafox pamelafox added the vnet label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants