Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make this a fork of the parent repo - https://github.com/spring-petclinic/spring-petclinic-microservices #31

Open
selvasingh opened this issue Sep 14, 2024 · 4 comments
Assignees

Comments

@selvasingh
Copy link
Contributor

Please make this a fork of the parent repo. This way - it can be listed among the available forks for petclinic and directly absorb all the changes happening on the parent repo

@vermegi
Copy link
Collaborator

vermegi commented Sep 20, 2024

Related to #33
If we pull in the latest from https://github.com/spring-petclinic/spring-petclinic-microservices we will also have the upgrade to Spring Boot 3.2.7.

@vermegi
Copy link
Collaborator

vermegi commented Sep 20, 2024

Prefer to provide a new copy of the base repo at https://github.com/spring-petclinic/spring-petclinic-microservices instead of forking from it. Although indeed if we fork, we can see when we are drifting from the base repo.

Also, @selvasingh how can we make this existing repo a fork of https://github.com/spring-petclinic/spring-petclinic-microservices? Would we need to recreate this Azure-Samples/java-microservices-aca-lab repo?

@selvasingh
Copy link
Contributor Author

Yes, a simple recreation will help

@vermegi
Copy link
Collaborator

vermegi commented Sep 25, 2024

Thing is that there is quite some ongoing work on the repo currently ... like people working on forks ... they would have a merge hell.
So basically what are your thoughts on this PR #44? That's a fresh copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants