-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming #27
Comments
I would like to work on that! |
Awesome, I will assign it to you! Since we're using the Chat Protocol SDK, you'll want to adhere the backend to that and then use the streaming method on the frontend. The azure-search-openai-demo already conforms to the protocol backend, so you can take a similar approach there, adding a /stream endpoint that returns json-lines. The azure-search-openai-demo frontend doesn't yet use the Chat Protocol SDK in the main branch, but I did bring it in in a branch here: You can also compare that with the protocol SDK react sample here: However, azure-search-openai-demo implements a setTimeout that works better for token-by-token streaming than the sample in that repo. Let me know if any questions along the way. |
Oh, and confession: there are no true tests for this repo yet. A bit embarassed to admit that since you saw my workshop yesterday on testing! So you will need to manual testing, or be the first to add tests. |
Thanks for the explanation! ❤️ I finally managed to add streaming to my sample yesterday that's why I wanted to add it here too. Azure-Samples/Cosmic-Food-RAG-app#39 I didn't show up here earlier as I just figured this out yesterday. I will work on some tests too. |
Related to #26, customers would like streaming. Can use Chat Protocol SDK
The text was updated successfully, but these errors were encountered: