Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Update AKS Storage based on PM Lorraine Bichara Assad's feedback #446

Merged
merged 11 commits into from
Apr 5, 2024

Conversation

pinyuko
Copy link
Contributor

@pinyuko pinyuko commented Apr 5, 2024

Overview/Summary

Update AKS Storage-related APRL based on PM Lorraine Bichara Assad's feedback

Related Issues/Work Items

Replace this with a list of related GitHub Issues and/or ADO Work Items (Internal Only)

  • To associate a GitHub Issue, use a key word preceded with the GitHub issue number.
  • To associate an ADO Work Item, use the key word AB# succeeded with the ADO Work Item ID.

This PR fixes/adds/changes/removes

  1. AKS-8
  2. AKS-9
  3. AKS-14
  4. Added AKS-9.fix PM Lorraine Bichara Assad shared Kusto query code, need help to change to customer-facing Azure Resource Graph Query

Breaking Changes

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries and/or scripts
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

PM Lorraine Bichara Assad shared Kusto query code, need help to change to customer-facing Azure Resource Graph Query
@pinyuko pinyuko marked this pull request as ready for review April 5, 2024 00:27
@pinyuko pinyuko requested a review from a team as a code owner April 5, 2024 00:27
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thanks for adding the context for the KQL.

Copy link
Contributor

@edknox edknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorbichara
Copy link

@oZakari On the query, I'm not super familiar with Azure Resource Graph Query so couldn't provide a query for that, but attached the KQL one! Happy to work together to figure out if there's an equivalent we can include!

Copy link
Contributor

@rodrigosantosms rodrigosantosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed query

@rodrigosantosms rodrigosantosms merged commit 03a389f into Azure:main Apr 5, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants