This repository has been archived by the owner on May 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 133
Update AKS Storage based on PM Lorraine Bichara Assad's feedback #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PM Lorraine Bichara Assad shared Kusto query code, need help to change to customer-facing Azure Resource Graph Query
oZakari
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and thanks for adding the context for the KQL.
oZakari
approved these changes
Apr 5, 2024
edknox
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@oZakari On the query, I'm not super familiar with Azure Resource Graph Query so couldn't provide a query for that, but attached the KQL one! Happy to work together to figure out if there's an equivalent we can include! |
rodrigosantosms
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed query
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Update AKS Storage-related APRL based on PM Lorraine Bichara Assad's feedback
Related Issues/Work Items
Replace this with a list of related GitHub Issues and/or ADO Work Items (Internal Only)
AB#
succeeded with the ADO Work Item ID.This PR fixes/adds/changes/removes
Breaking Changes
N/A
As part of this Pull Request I have
main
branch