Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerInvalidSettings when using --pull=always #139

Open
JulesHuisman opened this issue Oct 7, 2022 · 3 comments
Open

ContainerInvalidSettings when using --pull=always #139

JulesHuisman opened this issue Oct 7, 2022 · 3 comments
Labels
feature request Feature request

Comments

@JulesHuisman
Copy link

When launching a task with container_run_options='--rm --pull=always --workdir=/app'. The task fails with a ContainerInvalidSettings error. Saying the --pull=always is not valid. Is this behaviour blocked on purpose, or is this a bug?

image

@staer
Copy link
Contributor

staer commented Oct 7, 2022

I just checked the sources and it is indeed not parsed which is generating the error. I will check with the author if this was on purpose. I suspect it may be since when using containers in batch the pull is actually done outside of the "docker run" command. Container pulls happen at the VM level or at the task level when you specify which container to execute in. Batch will pull the container for you prior to invoking the docker run on behalf of your task.

@staer staer added the under investigation Under investigation by team label Oct 7, 2022
@JulesHuisman
Copy link
Author

Thanks for the quick response! It is probably a bit of a niche use case. As we want to keep one VM running for quicker response times, however this means the docker image could be updated in the meantime. So just to be safe I would like the tasks to always pull the latest image.

@staer
Copy link
Contributor

staer commented Oct 7, 2022

Ah ok, this makes sense as the way the implementation currently works is to just check locally for the container image, and if it doesn't exist pull it. Your use case makes sense though.

@alfpark alfpark added feature request Feature request and removed under investigation Under investigation by team labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

3 participants