Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Calling SDK crash for invalid ACS token #411

Open
iaulakh opened this issue Nov 2, 2021 · 2 comments
Open

[Android] Calling SDK crash for invalid ACS token #411

iaulakh opened this issue Nov 2, 2021 · 2 comments
Labels
Bug Something isn't working Needs: triage 🔍

Comments

@iaulakh
Copy link
Member

iaulakh commented Nov 2, 2021

For invalid ACS token, calling SDK crash with below message.
E/com.azure.android.communication.common.AutoRefreshUserCredential: java.lang.IllegalArgumentException: 'tokenStr' is not a valid token string

It will be great if SDK can provide handler to catch this error.

Steps:
The issue can be reproduced by injecting invalid function in CommunicationTokenRefreshOptions that returns invalid token.

val communicationTokenRefreshOptions = CommunicationTokenRefreshOptions(::getToken, true)
private fun getToken(): String {
return "token!!"
}

Version: com.azure.android:azure-communication-calling:1.2.1-beta.1
Device: Google Pixel 4a (Android 12)

@iaulakh iaulakh added the Bug Something isn't working label Nov 2, 2021
@ghost ghost added the Needs: triage 🔍 label Nov 2, 2021
@iaulakh
Copy link
Member Author

iaulakh commented Nov 2, 2021

@phileo99
Copy link

phileo99 commented Nov 8, 2021

CallClient.createCallAgent() is swallowing all exceptions, so then the CompletableFuture exception handling cannot run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs: triage 🔍
Projects
None yet
Development

No branches or pull requests

2 participants