Casing fixes of param for Azure Files DNS (#1407)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Azure · Aug 25, 2023 · 12e12bb · 12e12bb
1 parent 236a023
commit 12e12bb
Show file tree

Hide file tree

Showing 5 changed files with 57 additions and 18 deletions.
diff --git a/eslzArm/managementGroupTemplates/policyDefinitions/policies.json b/eslzArm/managementGroupTemplates/policyDefinitions/policies.json
diff --git a/eslzArm/managementGroupTemplates/roleDefinitions/customRoleDefinitions.json b/eslzArm/managementGroupTemplates/roleDefinitions/customRoleDefinitions.json
@@ -4,8 +4,8 @@
   "metadata": {
     "_generator": {
       "name": "bicep",
-      "version": "0.19.5.34762",
-      "templateHash": "10448217912583139124"
+      "version": "0.20.4.51522",
+      "templateHash": "11768655431175792812"
     }
   },
   "variables": {

diff --git a/...icrosoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.AzureChinaCloud.json b/...icrosoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.AzureChinaCloud.json
@@ -8,7 +8,7 @@
     "displayName": "Configure Azure PaaS services to use private DNS zones",
     "description": "This policy initiative is a group of policies that ensures private endpoints to Azure PaaS services are integrated with Azure Private DNS zones",
     "metadata": {
-      "version": "1.0.0",
+      "version": "1.0.1",
       "category": "Network",
       "source": "https://github.com/Azure/Enterprise-Scale/",
       "alzCloudEnvironments": [
@@ -18,6 +18,7 @@
     "parameters": {
       "azureFilePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureFilePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -26,6 +27,7 @@
       },
       "azureWebPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureWebPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -34,6 +36,7 @@
       },
       "azureBatchPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureBatchPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -42,6 +45,7 @@
       },
       "azureAppPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureAppPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -50,6 +54,7 @@
       },
       "azureAsrPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureAsrPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -58,6 +63,7 @@
       },
       "azureIotPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureIotPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -66,6 +72,7 @@
       },
       "azureKeyVaultPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureKeyVaultPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -74,6 +81,7 @@
       },
       "azureSignalRPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureSignalRPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -82,6 +90,7 @@
       },
       "azureAppServicesPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureAppServicesPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -90,6 +99,7 @@
       },
       "azureEventGridTopicsPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureEventGridTopicsPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -98,6 +108,7 @@
       },
       "azureDiskAccessPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureDiskAccessPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -106,6 +117,7 @@
       },
       "azureCognitiveServicesPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureCognitiveServicesPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -114,6 +126,7 @@
       },
       "azureIotHubsPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureIotHubsPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -122,6 +135,7 @@
       },
       "azureEventGridDomainsPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureEventGridDomainsPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -130,6 +144,7 @@
       },
       "azureRedisCachePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureRedisCachePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -138,6 +153,7 @@
       },
       "azureAcrPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureAcrPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -146,6 +162,7 @@
       },
       "azureEventHubNamespacePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureEventHubNamespacePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -154,6 +171,7 @@
       },
       "azureMachineLearningWorkspacePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureMachineLearningWorkspacePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -162,6 +180,7 @@
       },
       "azureServiceBusNamespacePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureServiceBusNamespacePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -170,6 +189,7 @@
       },
       "azureCognitiveSearchPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureCognitiveSearchPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -207,7 +227,7 @@
         "policyDefinitionId": "/providers/Microsoft.Management/managementGroups/contoso/providers/Microsoft.Authorization/policyDefinitions/Deploy-Private-DNS-Azure-File-Sync",
         "parameters": {
           "privateDnsZoneId": {
-            "value": "[[parameters('azureFileprivateDnsZoneId')]"
+            "value": "[[parameters('azureFilePrivateDnsZoneId')]"
           },
           "effect": {
             "value": "[[parameters('effect')]"

diff --git a/...rosoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.AzureUSGovernment.json b/...rosoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.AzureUSGovernment.json
@@ -8,7 +8,7 @@
     "displayName": "Configure Azure PaaS services to use private DNS zones",
     "description": "This policy initiative is a group of policies that ensures private endpoints to Azure PaaS services are integrated with Azure Private DNS zones",
     "metadata": {
-      "version": "1.0.0",
+      "version": "1.0.1",
       "category": "Network",
       "source": "https://github.com/Azure/Enterprise-Scale/",
       "alzCloudEnvironments": [
@@ -18,6 +18,7 @@
     "parameters": {
       "azureFilePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureFilePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -26,6 +27,7 @@
       },
       "azureBatchPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureBatchPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -34,6 +36,7 @@
       },
       "azureAppPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureAppPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -42,6 +45,7 @@
       },
       "azureAsrPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureAsrPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -50,6 +54,7 @@
       },
       "azureIotPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureIotPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -58,6 +63,7 @@
       },
       "azureKeyVaultPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureKeyVaultPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -66,6 +72,7 @@
       },
       "azureSignalRPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureSignalRPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -74,6 +81,7 @@
       },
       "azureAppServicesPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureAppServicesPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -82,6 +90,7 @@
       },
       "azureEventGridTopicsPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureEventGridTopicsPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -90,6 +99,7 @@
       },
       "azureDiskAccessPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureDiskAccessPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -98,6 +108,7 @@
       },
       "azureCognitiveServicesPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureCognitiveServicesPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -106,6 +117,7 @@
       },
       "azureIotHubsPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureIotHubsPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -114,6 +126,7 @@
       },
       "azureEventGridDomainsPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureEventGridDomainsPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -122,6 +135,7 @@
       },
       "azureRedisCachePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureRedisCachePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -130,6 +144,7 @@
       },
       "azureAcrPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureAcrPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -138,6 +153,7 @@
       },
       "azureEventHubNamespacePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureEventHubNamespacePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -146,6 +162,7 @@
       },
       "azureMachineLearningWorkspacePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureMachineLearningWorkspacePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -154,6 +171,7 @@
       },
       "azureServiceBusNamespacePrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureServiceBusNamespacePrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -162,6 +180,7 @@
       },
       "azureCognitiveSearchPrivateDnsZoneId": {
         "type": "string",
+        "defaultValue": "",
         "metadata": {
           "displayName": "azureCognitiveSearchPrivateDnsZoneId",
           "strongType": "Microsoft.Network/privateDnsZones",
@@ -199,7 +218,7 @@
         "policyDefinitionId": "/providers/Microsoft.Authorization/policyDefinitions/06695360-db88-47f6-b976-7500d4297475",
         "parameters": {
           "privateDnsZoneId": {
-            "value": "[[parameters('azureFileprivateDnsZoneId')]"
+            "value": "[[parameters('azureFilePrivateDnsZoneId')]"
           },
           "effect": {
             "value": "[[parameters('effect')]"
@@ -444,4 +463,4 @@
     ],
     "policyDefinitionGroups": null
   }
-}
+}
diff --git a/src/resources/Microsoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.json b/src/resources/Microsoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.json
@@ -8,7 +8,7 @@
     "displayName": "Configure Azure PaaS services to use private DNS zones",
     "description": "This policy initiative is a group of policies that ensures private endpoints to Azure PaaS services are integrated with Azure Private DNS zones",
     "metadata": {
-      "version": "1.1.0",
+      "version": "1.1.1",
       "category": "Network",
       "source": "https://github.com/Azure/Enterprise-Scale/",
       "alzCloudEnvironments": [
@@ -506,7 +506,7 @@
         "policyDefinitionId": "/providers/Microsoft.Authorization/policyDefinitions/06695360-db88-47f6-b976-7500d4297475",
         "parameters": {
           "privateDnsZoneId": {
-            "value": "[[parameters('azureFileprivateDnsZoneId')]"
+            "value": "[[parameters('azureFilePrivateDnsZoneId')]"
           },
           "effect": {
             "value": "[[parameters('effect')]"