Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy: Implement DenyAction #1399

Closed
wants to merge 22 commits into from
Closed

Policy: Implement DenyAction #1399

wants to merge 22 commits into from
+208 −77

Conversation

4pplied
Copy link
Contributor

@4pplied 4pplied commented Aug 4, 2023 •
edited by azure-boards bot
Loading

Overview/Summary

Implementation of DenyAction Delete into Azure Landing Zones for both Activity Logs and Diagnostic Settings as two seperate policy definitions and a policy initiative.

Address story AB#29619

This PR fixes/adds/changes/removes

  1. Two policy definitions for DenyAction Delete Activity Logs and Diagnostic Settings
  2. A policy initiative to apply these two policy definitions

Breaking Changes

  1. N/A

Testing Evidence

To Be Delivered.

Testing URLs

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [] Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone added this to the policy-refresh-fy24-q1 milestone Aug 4, 2023
@4pplied 4pplied marked this pull request as draft August 4, 2023 15:16
@4pplied 4pplied marked this pull request as ready for review August 6, 2023 15:40
@Springstone
Copy link
Member

Please redirect the PR to the policy-refresh-q1fy24 branch

@Springstone Springstone changed the title US 29619 - Policy: Implement DenyAction Policy: Implement DenyAction Aug 7, 2023
@4pplied 4pplied changed the base branch from main to policy-refresh-q1fy24 August 8, 2023 10:02
@Springstone Springstone added PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments and removed Needs: Author Feedback labels Aug 8, 2023
@Springstone Springstone closed this Aug 8, 2023
@Springstone Springstone reopened this Aug 8, 2023
@github-actions github-actions bot requested a review from a team as a code owner August 8, 2023 10:32
@Springstone Springstone closed this Aug 8, 2023
@Springstone Springstone reopened this Aug 8, 2023
@Springstone Springstone closed this Aug 8, 2023
@Springstone Springstone reopened this Aug 8, 2023
@4pplied 4pplied requested a review from a team as a code owner August 15, 2023 14:33
@4pplied 4pplied closed this Aug 15, 2023
@4pplied 4pplied reopened this Aug 15, 2023
@Springstone Springstone reopened this Aug 15, 2023
@4pplied 4pplied closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Milestone
policy-refresh-fy24-q1
Development

Successfully merging this pull request may close these issues.
2 participants
@4pplied @Springstone