Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ALZ Repo (Enterprise-scale) with Entra product names #1411

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

lachaves
Copy link
Contributor

@lachaves lachaves commented Aug 28, 2023

Overview/Summary

This PR fixes Issue #1410 and ADO User Story 29734

This PR fixes/adds/changes/removes

  1. Update ALZ Repo (Enterprise-scale) with Entra product names

Breaking Changes

NA

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
image

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

  • [X ] Checked for duplicate Pull Requests
  • [X ] Associated it with relevant issues, for tracking and closure.
  • [X ] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • [X ] Ensured contribution guidance is followed.
  • [X ] Updated relevant and associated documentation.
  • [X ] Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@jtracey93 jtracey93 linked an issue Aug 29, 2023 that may be closed by this pull request
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lachaves, is it not a "Microsoft Entra ID Tenant"?

@jtracey93 jtracey93 added the documentation Improvements or additions to documentation label Aug 29, 2023
@lachaves
Copy link
Contributor Author

Hi @jtracey93, based on the Azure AD naming Guide and Glossary document the individual Microsoft Entra services dont use the ID word in them, for example, Microsoft Entra Sync, Microsoft Entra tenant, etc.
I reviewed individually every replacement and changed based on the naming guidelines.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Needs attention from the maintainers and removed Needs: Author Feedback labels Aug 30, 2023
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 8790878 into Azure:main Aug 31, 2023
5 checks passed
TwanVerdel added a commit to TwanVerdel/Enterprise-Scale that referenced this pull request Sep 7, 2023
Update ALZ Repo (Enterprise-scale) with Entra product names (Azure#1411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Needs: Attention 👋 Needs attention from the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ALZ Repo (Enterprise-scale) with Entra product names
2 participants