-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMA Updates #1649
Merged
Merged
AMA Updates #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Springstone
added
PR: Safe to test 🧪
PRs can run more advanced tests that may deploy or access environments
Area: Policy 📝
Issues / PR's related to Policy
labels
May 28, 2024
Springstone
requested changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes and a question. Can you also please add a little more to What's New / AMA about how we've implemented the change to single UAMI, in particular what we default to now in ALZ portal
"userAssignedIdentityResourceId": "[concat('/subscriptions/', variables('singleVsDedicatedMgmtSub'), '/resourceGroups/', variables('platformRgNames').mgmtRg, '/providers/Microsoft.ManagedIdentity/userAssignedIdentities/', variables('platformResourceNames').userAssignedIdentity)]"
Otherwise an outstanding PR!
...Microsoft.Authorization/policyDefinitions/Deploy-UserAssignedManagedIdentity-VMInsights.json
Outdated
Show resolved
Hide resolved
…-UserAssignedManagedIdentity-VMInsights.json Co-authored-by: Sacha Narinx <[email protected]>
5 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Policy 📝
Issues / PR's related to Policy
PR: Safe to test 🧪
PRs can run more advanced tests that may deploy or access environments
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Introduces the use of a single centralized User Assigned Managed Identity for AMA. Policy and Initiative assignments have been updated with new parameters.
This PR fixes/adds/changes/removes
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)