Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Supplementry typo #1714

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix Supplementry typo #1714

merged 1 commit into from
Aug 12, 2024

Conversation

jamiepla1
Copy link
Contributor

Overview/Summary

fix typo for "Key Vault - Supplementry" to be "Key Vault - Supplementary" - 2 instances of the typo.

This PR fixes/adds/changes/removes

  1. fix typo for "Key Vault - Supplementry" to be "Key Vault - Supplementary" - 2 instances of the typo.

Breaking Changes

  1. n/a- just text changes

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Testing below is successful

https://portal.azure.com/#view/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fjamiepla1%2FEnterprise-Scale%2Fjp-fix-typos%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2Fjamiepla1%2FEnterprise-Scale%2Fjp-fix-typos%2FeslzArm%2Feslz-portal.json

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • [n/a] Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@jamiepla1 jamiepla1 requested a review from a team as a code owner July 26, 2024 15:28
@jamiepla1 jamiepla1 changed the title fix Supplementry typo Fix Supplementry typo Jul 26, 2024
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate
Copy link
Member

@Springstone I'll let you verify and merge this.

@jtracey93 jtracey93 merged commit 0b8d048 into Azure:main Aug 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants