Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all fix to a workable version for mooncake (Azure China) #1759

Merged
merged 46 commits into from
Oct 29, 2024

Conversation

yuanzhang9
Copy link

Changes on initiative definition and assignment due to missing build-in policy in mooncake:
Add new policy assignments à eslzArm\managementGroupTemplates\policyAssignments\china
Add new initiatives definition à src\resources\Microsoft.Authorization\policySetDefinitions
Update Bicep file on context loading à src\templates\initiatives.bicep, src\templates\policies.bicep
Update ARM template to load different assignments à eslzArm\eslzArm.json

Changes on role assignment due to service
Disable role “Security Operation” and “Network Management” as service “Microsoft.Support/*” is not available in mooncake. à src\templates\roles.bicep

Hide some option from Portal GUI as the service/policy/initiative are not available nor supported in mooncake. à eslzArm\eslz-portal.json

Change on service configuration:
Add new configuration file for Azure Defender for Cloud since the 2024-01-01version of API(Microsoft.Security/pricings) is not supported. à eslzArm\subscriptionTemplates\mcmdfcConfiguration.json

@yuanzhang9 yuanzhang9 requested a review from a team as a code owner September 6, 2024 09:19
@Springstone Springstone closed this Sep 9, 2024
@Springstone Springstone reopened this Sep 9, 2024
@Springstone Springstone closed this Sep 9, 2024
@Springstone Springstone reopened this Sep 9, 2024
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to review, and please address the conflicts

@yuanzhang9
Copy link
Author

yuanzhang9 commented Sep 30, 2024

One more update for "Routing intent of vWAN hub", included in this PR as well. @Springstone

@Springstone Springstone merged commit 947cdfa into Azure:SovereignChina Oct 29, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants