-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include all fix to a workable version for mooncake (Azure China) #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1 not supported in mooncake
Springstone
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things to review, and please address the conflicts
src/resources/Microsoft.Authorization/policySetDefinitions/Enforce-ALZ-Decomm.json
Outdated
Show resolved
Hide resolved
...s/Microsoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.AzureChinaCloud.json
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Sep 26, 2024
One more update for "Routing intent of vWAN hub", included in this PR as well. @Springstone |
…initions.json This needs to be excluded as auto generated file.
Springstone
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes on initiative definition and assignment due to missing build-in policy in mooncake:
Add new policy assignments à eslzArm\managementGroupTemplates\policyAssignments\china
Add new initiatives definition à src\resources\Microsoft.Authorization\policySetDefinitions
Update Bicep file on context loading à src\templates\initiatives.bicep, src\templates\policies.bicep
Update ARM template to load different assignments à eslzArm\eslzArm.json
Changes on role assignment due to service
Disable role “Security Operation” and “Network Management” as service “Microsoft.Support/*” is not available in mooncake. à src\templates\roles.bicep
Hide some option from Portal GUI as the service/policy/initiative are not available nor supported in mooncake. à eslzArm\eslz-portal.json
Change on service configuration:
Add new configuration file for Azure Defender for Cloud since the 2024-01-01version of API(Microsoft.Security/pricings) is not supported. à eslzArm\subscriptionTemplates\mcmdfcConfiguration.json