Skip to content

Commit 8aaecfa

Browse files
committed
refactor are_all_requested_packages_installed
1 parent 7d909f0 commit 8aaecfa

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/core/src/core_logic/PatchInstaller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -836,7 +836,7 @@ def log_final_installation_metric(self, patch_installation_successful, maintenan
836836
def __check_installation_status_can_set_to_warning(self, patch_installation_successful, maintenance_window_exceeded):
837837
""" Verify patch installation status can be set to warning from failed. """
838838
# type (bool, bool) -> bool
839-
self.__enable_installation_status_to_warning_flag = not patch_installation_successful and not maintenance_window_exceeded and self.status_handler.check_all_requested_packages_install_state()
839+
self.__enable_installation_status_to_warning_flag = not patch_installation_successful and not maintenance_window_exceeded and self.status_handler.are_all_requested_packages_installed()
840840
return self.__enable_installation_status_to_warning_flag
841841

842842
def set_patch_installation_status_to_warning_from_failed(self):

src/core/src/service_interfaces/StatusHandler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ def get_os_name_and_version(self):
263263
self.composite_logger.log_error("Unable to determine platform information: {0}".format(repr(error)))
264264
return "unknownDist_unknownVer"
265265

266-
def check_all_requested_packages_install_state(self):
266+
def are_all_requested_packages_installed(self):
267267
# type (none) -> bool
268268
""" Check if all requested package(s) are installed. """
269269

src/core/tests/Test_CoreMain.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1332,11 +1332,11 @@ def test_warning_status_when_packages_initially_fail_but_succeed_on_retry_no_bat
13321332

13331333
# Store original methods
13341334
original_batch_patching = runtime.patch_installer.batch_patching
1335-
original_check_all_requested_packages_install_state= runtime.status_handler.check_all_requested_packages_install_state
1335+
original_check_all_requested_packages_install_state= runtime.status_handler.are_all_requested_packages_installed
13361336

13371337
# Mock batch_patching with packages to return [], [], false
13381338
runtime.patch_installer.batch_patching = self.mock_batch_patching_with_no_packages
1339-
runtime.status_handler.check_all_requested_packages_install_state = self.mock_check_all_requested_packages_install_state
1339+
runtime.status_handler.are_all_requested_packages_installed = self.mock_check_all_requested_packages_install_state
13401340

13411341
# Run CoreMain to execute the installation
13421342
try:

0 commit comments

Comments
 (0)