-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Stack Architecture documentation (not diagram) #116
Comments
All these features are documented in the parameters file (this is autogenerated so should always represent the complete feature set). It would be good to document properly, I agree. |
Would be good to have someone review what I added. I'm a bit unclear on how many Tika VMs we provide for example, and all the ways in which we use App Gateway, Key Vault, etc. today in the template. Also, it'd be good to have some more notes in the section where we talk about "Observations about the current template" - unless we plan to have more documentation on these features elsewhere. |
Hello @taylora3,
Apologies for the lack of the AppGw documentation in our templates. We'll add more documentation on this soon, but currently the only available one is at the corresponding template source code. Look at the "description" values in here. The same convention (your KeyVault's Azure resource ID and the KeyVault URL for your cert uploaded as a "secret"--in the pfx format--onto your KeyVault) applies here. So if you have a PEM-format cert, you'll need to convert it to a PFX cert (with no password) and upload it to your KeyVault as a "secret", NOT as a "certificate". This is quite inconvenient, I think, for most people from non-Windows world, but that's how the current Azure KeyVault and Resource Manager secret handling is done. For more information on how App Gateway can accept an SSL cert, please refer to this. As you can see, App Gateway API accepts only a base64-encoded cert content as its parameter. Since we don't want customers to pass their SSL certs this way, we had to rely on the general ARM secret handling as described here, and this is where the PFX format and "secret"-not-"certificate" quirkiness get in. Hope this helps and feel free to reach out to me by email if you have some things that you don't feel comfortable sharing over this public forum. Thanks. |
@hosungsmsft thanks for the reply. I was given a .crt .cer .pfx .key files by my ssl certificate provider. Do I still need to regenerate the .pfx file from the .crt file? Is the below a legitimate version of running the script: I think the "secret", NOT as a "certificate" part of this is tripping me up. Is there a way of adding the pfx file as a secret to Azure without using the CLI or the script. I was uploading the PFX as a certificate and getting all the values from the UI. |
@taylora3 -- Just wanted to make sure that you are trying this for https termination at your VMSS resource, NOT for an App Gateway https termination (because for App Gateway, the Assuming that you are trying to use your valid SSL cert (that you purchased from your SSL cert provider), hopefully the keyvault.sh is a good enough tool, but that script has some specific assumptions/requirements. I assume your Please note that a *.cer file might not be in the binary DER format, but in the PEM (base64-encoded) format. It feels like that might be the case here, because the file name ( Assuming your
Of course you should run Yes I find it confusing to have to upload a cert as a secret after encoding the .pfx file into base64 format, and compose a specific JSON-formatted content as in the Please do let us know again if you have further questions. Best luck on your SSL setup. Thanks. |
@hosungsmsft thankyou for the very clear response. I am specifically trying to get it to work for an App Gateway. Could you point me in the direction of what I would need to do to get the App gateway working? Thanks again :) |
@taylora3 -- For AppGw, please note that I haven't tested the AppGw option that much. The only test case I could conduct was to create, using opensll, a self-signed SSL cert and private key (not purchased, thus not signed by a valid CA), which are in PEM format, convert it to PFX (Azure requirements, done using openssl, and this PFX should NOT be password-protected currently by our templates), upload it to my Azure KeyVault and use it with our templates for the AppGw test. So what I'm going to tell you may not work exactly as hoped, and in that case, please feel free to reach out to me by email and we may try some remote screen-shared online meeting session to resolve this. Not sure if your cert provider gave you a PFX file which is password protected, but if it is, we need to first remove the password (because our Once you have a PFX file for your cert without a password, you need to upload the PFX file's content to your Azure KeyVault after encoding the binary file content in base64 format. This can be achieved using a command like the following (on a Linux shell with Azure CLI. Let me know if your environment is different):
Then finally you can pass Hope this helps and feel free to reach out to me by email if you'd like to go over this together on a screen-shared online meeting. Of course feel free to leave more questions here as well. Thanks, |
Sorry, the command above has a bug. The
|
It's been a while since we've updated this. Right now the written description of the stack architecture does not include the work around Application Gateway, Key Vault, Tika VMs, DDOS Protection, etc. Can we update it?
The text was updated successfully, but these errors were encountered: