Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify a node pool VM to delete (with or without scaling) #370

Open
eponerine opened this issue Jan 22, 2024 · 1 comment

Comments

@eponerine
Copy link

eponerine commented Jan 22, 2024

Title:
Allow users to specify a node pool VM to delete (with or without scaling)

Description:
In simple terms, it would be slick to provide the logic to target a specific VM to kill; whether independently or when scaling down a node pool.

For scaling, perhaps add a new parameter only validates and works if the -count parameter is less-than current count. Something like -targetVM or -targetNode

As an example, let's say you have the following:

  • AKS Cluster Name: k8scluster01
  • Pool Name: k8scluster01linuxpool01

And in that pool, you have 3 nodes with VM names:

  • k8scluster01linuxpool01-AAAAAAA
  • k8scluster01linuxpool01-BBBBBBBB
  • k8scluster01linuxpool01-CCCCCCC

And assume that k8scluster01linuxpool01-CCCCCCC has some kind of failure that has to be manually fixed by simply deleting the entire VM from the cluster.

If we had the ability to run Set-AksHciNodePool -clusterName "k8scluster01" -name "k8scluster01linuxpool01" -count 2 -targetNode "k8scluster01linuxpool01-CCCCCCC" , it would be smart enough to see that -count 2 is less than current value and we are targeting a specific VM to remove.

For non-scaling situations where you just want to kill a VM and have it respawn, make a new cmdlet called Remove-AksHciNodePoolVM or Remove-AksHciNodePoolNode that handles this logic.

@eponerine
Copy link
Author

This would be useful for this very very old issue:
#8

@eponerine eponerine changed the title Specify which node pool VM to remove when scaling down via Set-AksHciNodePool Allow users to specify a node pool VM to delete (with or without scaling) Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant