Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Property name is changed after clicommon #86

Open
chunyu3 opened this issue Jul 21, 2020 · 2 comments
Open

Property name is changed after clicommon #86

chunyu3 opened this issue Jul 21, 2020 · 2 comments
Assignees

Comments

@chunyu3
Copy link
Member

chunyu3 commented Jul 21, 2020

The property names may changed to lowcase after clicommon. e.g. ***SQL is changed to ***Sql. Because in clicommon it will transform to PASCAL , then CAMEL, then PASCAL, then some keywords with with all uppercase Characters will be changed to lowcase.
e.g.
In Securityinsights

Some property names have changed to lowcase after clicommon.

TI
MCAS

@chunyu3
Copy link
Member Author

chunyu3 commented Jul 21, 2020

Need to check the rules of how to handle those keywords in Modeler v4, and apply those rules into clicommon.

@shawncx shawncx self-assigned this Jul 21, 2020
@shawncx
Copy link
Contributor

shawncx commented Jul 21, 2020

I tried Securityinsights. The output of clicommon seems correct

- schemaName: TIDataConnector
        cli:
          cli-discriminator-value: ThreatIntelligence
          cliKey: TIDataConnector
          cli-complexity: object_complex

- schemaName: MCASDataConnector
        cli:
          cli-discriminator-value: MicrosoftCloudAppSecurity
          cliKey: MCASDataConnector
          cli-complexity: object_complex

I think it is because we have following override in cli readme

        default:
            override:
                cmyk : CMYK
                $host: $host
                LRO: LRO
                rp: RP
                db: DB
                adls: ADLS
                dw: DW
                ti: TI
                MCAS: MCAS
                mdatp: MDATP
                aad: AAD
                aat: AAT
                asc: ASC
                aatp: AATP
                UTC: UTC
                SSL: SSL
                Sql: SQL
                Rc: RC
                Gb: GB

Could you double check the issue? Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants