http-client-java, e2e test, use clientcore #5437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
weidongxu-microsoft
force-pushed
the
http-client-java_e2e-standard
branch
from
f84cc08 to
ff96a9d
Compare
packages/http-client-java/generator/http-client-generator-standard-test/Generate.ps1
Outdated
Show resolved
Hide resolved
|
You can try these changes here
|
Fix unbranded emitter, write test cases
weidongxu-microsoft
force-pushed
the
http-client-java_e2e-standard
branch
from
bdc469c to
cdcec31
Compare
weidongxu-microsoft
force-pushed
the
http-client-java_e2e-standard
branch
from
ee6429d to
38a23eb
Compare
This reverts commit 6139301.
weidongxu-microsoft
changed the title
Comment on lines
91
to
104
| # ServiceVersion not in core | ||
| Remove-Item ./specs/versioning -Recurse -Force | ||
| Remove-Item ./specs/server/path -Recurse -Force | ||
| Remove-Item ./specs/server/versions -Recurse -Force | ||
| # TokenCredential not in core | ||
| Remove-Item ./specs/authentication/oauth2 -Recurse -Force | ||
| Remove-Item ./specs/authentication/union -Recurse -Force | ||
| # Base64Url not in core | ||
| Remove-Item ./specs/encode/bytes -Recurse -Force | ||
| # DateTimeRfc1123 is private in beta.1, should now be public in main | ||
| Remove-Item ./specs/encode/datetime -Recurse -Force | ||
| Remove-Item ./specs/special-headers -Recurse -Force | ||
| # JacksonAdapter not in core | ||
| Remove-Item ./specs/encode/duration -Recurse -Force |
There was a problem hiding this comment.
At present, lots of tests is skipped, due to class/feature not available in clientcore (compile failure).
Some tests are also disabled (runtime failure).
We will later make a summary on these, and discuss what need to be fixed in clientcore, what need to be handled differently in emitter.
After clientcore beta.2 we likely can enable more test (I think I can see DateTimeRfc1123 be public in current code)
| @@ -52,7 +64,7 @@ try { | |||
| if (!(Test-Path $coverageReportDir)) { | |||
| New-Item -ItemType Directory -Path $coverageReportDir | |||
|
|
|||
| $sourceFile = Join-Path $packageRoot 'generator/http-client-generator-test/tsp-spector-coverage-java-standard.json' | |||
| $sourceFile = Join-Path $packageRoot 'generator/http-client-generator-clientcore-test/tsp-spector-coverage-java-standard.json' | |||
There was a problem hiding this comment.
Now we can finally take the report of unbranded e2e.
weidongxu-microsoft
requested review from
srnagar,
haolingdong-msft,
XiaofeiCao,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Azure/autorest.java#3000
fix Azure/autorest.java#3002
fix Azure/autorest.java#2986
Cases that generated code cannot compile is currently skipped.
Cases that not able to pass is disabled.
Current result https://specdashboard.z5.web.core.windows.net/
