Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub.SendBatch doesn't implement Sender.SendBatch anymore #171

Open
anabouna opened this issue Apr 22, 2020 · 0 comments
Open

Hub.SendBatch doesn't implement Sender.SendBatch anymore #171

anabouna opened this issue Apr 22, 2020 · 0 comments

Comments

@anabouna
Copy link

Expected Behavior

func (h *Hub) SendBatch(ctx context.Context, iterator BatchIterator, opts ...BatchOption) error

Implements

Sender.SendBatch (Hub is an implementation of Sender)

Actual Behavior

It's no longer the case after e7ca692

Can we update the interface to reflect the changes ?

Environment

  • OS: Write here
  • Go version: Write here
  • Version of Library: Write here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant