Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded azure storage blob to 0.14.0 #237

Closed
wants to merge 4 commits into from

Conversation

Nighthawk22
Copy link

@Nighthawk22 Nighthawk22 commented Sep 21, 2021

Fix or Enhancement?

Fix of compatible to most recent azure blob storage version.
Fixes #228

  • All tests passed
  • Add change to changelog.md

Breaks compatibility with older azblob versions.

TBD

Should it be possible to provide the customer provided keys? Currently they are neglected.

Environment

  • OS: mac OSx
  • Go version: 1.17

@ghost
Copy link

ghost commented Sep 21, 2021

CLA assistant check
All CLA requirements met.

@Nighthawk22 Nighthawk22 changed the title Upgraded azure storage blob to 0.13.0 Upgraded azure storage blob to 0.14.0 Sep 22, 2021
@Nighthawk22
Copy link
Author

Not sure who could take a look here. We have a pretty bad dependency lock in our project due to this. Would be awesome to get that in.

@richardpark-msft

@richardpark-msft
Copy link
Member

@Nighthawk22 - I am sorry I missed this one. I'm taking a look at it now.

@richardpark-msft
Copy link
Member

Just a little status update - there are some issues with the latest storage library and how we're doing authentication internally, so all the live tests using this are failing. Still looking at it.

@richardpark-msft
Copy link
Member

Hi @Nighthawk22, looking at this some more there are a few issues with moving to a newer version of the Storage-Blob package. We'll need to take a look at this in the nearer future.

The other complication is that I'm not able to reproduce the issue that spawned this bug in the first place, so it's not entirely clear if the update will fix it (unfortunately).

@richardpark-msft
Copy link
Member

Closing for now as I don't think we can merge it until we get the storage plan in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Storage Blob Go, has updated some functions parameters ( needs to be updated in Storage.go)
3 participants